Remove ssh_key_data fix, handled in runner now #13114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fosterseth I haven't forgotten about this. Just got delayed due to flake when trying to run integration tests. Restarted just now 🤞 |
|
tests are good |
AlanCoding
commented
Oct 28, 2022
requirements/requirements_git.txt
Outdated
| @@ -1,6 +1,6 @@ | |||
| git+https://github.com/ansible/system-certifi.git@devel#egg=certifi | |||
| # Remove pbr from requirements.in when moving ansible-runner to requirements.in | |||
| git+https://github.com/ansible/ansible-runner.git@devel#egg=ansible-runner | |||
| git+https://github.com/fosterseth/ansible-runner.git@fix_ssh_key_data_pipe_reading#egg=ansible-runner | |||
There was a problem hiding this comment.
We can undo this when the PR is merged.
fosterseth
approved these changes
Oct 28, 2022
|
I un-did the change to our git requirements. The runner change merged a few days ago, so this should be workable now. |
|
Finally confirmed that hang on production instances from before the runner fix, and confirmed it's still fixed with this change. Merging soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Making this PR for purposes of testing.
This does a complete 180 from #13102, and removes the hack as opposed to expanding its scope. Since the runner fix is in
unstream_dir, it should be active in the needed context.This makes use of the fix ansible/ansible-runner#1133
ISSUE TYPE
COMPONENT NAME