8000 AAP-46087 Adjust the default capacity_adjustment to 0.75 by jainnikhil30 · Pull Request #15989 · ansible/awx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AAP-46087 Adjust the default capacity_adjustment to 0.75 #15989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

AAP-46087 Adjust the default capacity_adjustment to 0.75 #15989

wants to merge 3 commits into from

Conversation

jainnikhil30
Copy link
Contributor
SUMMARY

It basically changes the default capacity_adjustment from 1.0 to 0.75

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API

@jainnikhil30 jainnikhil30 requested review from AlanCoding and kdelee May 15, 2025 10:40
@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.49%. Comparing base (01eb162) to head (e563565).
Report is 10 commits behind head on devel.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 1932 at 21505:26 in /home/runner/work/awx/awx/reports/junit.xml
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AlanCoding
AlanCoding reviewed May 15, 2025
View reviewed changes
awx/main/models/ha.py
@@ -160,7 +160,7 @@ def __str__(self):
default=100,
editable=False,
)
capacity_adjustment = models.DecimalField(default=Decimal(1.0), max_digits=3, decimal_places=2, validators=[MinValueValidator(Decimal(0.0))])
capacity_adjustment = models.DecimalField(default=Decimal(0.75), max_digits=3, decimal_places=2, validators=[MinValueValidator(Decimal(0.0))])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is tracked in migrations

awx/awx/main/migrations/0049_v330_validate_instance_capacity_adjustment.py

Line 19 in 01eb162

field=models.DecimalField(decimal_places=2, default=Decimal('1'), max_digits=3, validators=[django.core.validators.MinValueValidator(0)]),

So your change would require adding a new migration file. For temporary administrative reasons you are sure to be unaware of, this is going to be harder than you're thinking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanCoding thanks for the pointer Alan, let me see if I can create a migration for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanCoding I have added a migration file for it.

 8000

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jainnikhil30 jainnikhil30 requested a review from AlanCoding May 23, 2025 07:37
@AlanCoding AlanCoding changed the title Adjust the default capacity_adjustment to 0.75 AAP-46087 Adjust the default capacity_adjustment to 0.75 May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelee kdelee Awaiting requested review from kdelee

@AlanCoding AlanCoding Awaiting requested review from AlanCoding

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jainnikhil30 @AlanCoding
0