-
Notifications
You must be signed in to change notification settings - Fork 125
Azure servicebus - add async functionality #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @susanhooks |
Thank you, I will update tests for this. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@Alex-Izquierdo - I've updated tests and got CI passing. Please let me know if you need anything else from me. |
Thank you for this contribution. We are in the process of moving the azure specific plugin to the upsteam azure collection. https://github.com/ansible-collections/azure/tree/dev/extensions/eda Would you mind re-submiting this PR to that collection? When I did the initial migration I was careful to keep all the git history so I would really like your commit to come from you. We should be doing a release of the azure collection at the end of July which will then allow us to deprecate the module in this collection. Thanks! |
Let's keep this process light on contributors (be them Red Hat folks or external) for now; I created a PR forwarding the commit as-is of this change: ansible-collections/azure#2017 |
This PR is to fix the issue #401 , in which the async functionality was not working as expected. I've rewritten this module to leverage the Azure Service Bus async functionality.
In my testing, this resolves the QueueFull message that was being received when a large number of events needed to be processed.