8000 Azure servicebus - add async functionality by susanhooks · Pull Request #451 · ansible/event-driven-ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Azure servicebus - add async functionality #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 10, 2025

Conversation

susanhooks
Copy link
Contributor

This PR is to fix the issue #401 , in which the async functionality was not working as expected. I've rewritten this module to leverage the Azure Service Bus async functionality.

In my testing, this resolves the QueueFull message that was being received when a large number of events needed to be processed.

@Alex-Izquierdo
Copy link
Contributor

Hi @susanhooks
Thank you very much for you contribution. The PR looks good but as you can see in the CI, your changes need also to update the tests.

@susanhooks
Copy link
Contributor Author

Hi @susanhooks Thank you very much for you contribution. The PR looks good but as you can see in the CI, your changes need also to update the tests.

Thank you, I will update tests for this.

@susanhooks
Copy link
Contributor Author

@Alex-Izquierdo - I've updated tests and got CI passing. Please let me know if you need anything else from me.

8000
@Alex-Izquierdo Alex-Izquierdo requested a review from a team July 9, 2025 10:55
@Alex-Izquierdo Alex-Izquierdo merged commit f9905e3 into ansible:main Jul 10, 2025
18 checks passed
@p3ck
Copy link
p3ck commented Jul 16, 2025

Thank you for this contribution. We are in the process of moving the azure specific plugin to the upsteam azure collection.

https://github.com/ansible-collections/azure/tree/dev/extensions/eda

Would you mind re-submiting this PR to that collection? When I did the initial migration I was careful to keep all the git history so I would really like your commit to come from you.

We should be doing a release of the azure collection at the end of July which will then allow us to deprecate the module in this collection.

Thanks!

@ptoscano
Copy link
Contributor

Would you mind re-submiting this PR to that collection? When I did the initial migration I was careful to keep all the git history so I would really like your commit to come from you.

Let's keep this process light on contributors (be them Red Hat folks or external) for now; I created a PR forwarding the commit as-is of this change: ansible-collections/azure#2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants
0