This repository was archived by the owner on Dec 2, 2022. It is now read-only.
Remove modules from schemas #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Dec 21, 2021
| @@ -20,6 +20,7 @@ commands = | |||
| # we use npm/mocha to perform testing instead of pytest, mainly because | |||
| # ajv-cli does not allow passing options we need. | |||
| # {envpython} -m pytest | |||
| npm run test | |||
There was a problem hiding this comment.
Why is this included with the schema removal?
There was a problem hiding this comment.
Safety. I wanted to see that testing passes. Less than ideal but with current state of affairs...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will no longer check module names and arguments as part of playbook and tasks schemas as these features are greatly dependent of local configuration and they do not scale well.
To be clear there is no JSON validator that can cope with a full schema that checks modules, even if we would generate one.
We will recommend users to use one of the editors that can make use of https://github.com/ansible/ansible-language-server
These schemas ar still valid but you should be aware of their limitations.