8000 Add new property for MoleculePlatformModel by egarbi · Pull Request #50 · ansible/schemas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 2, 2022. It is now read-only.

Add new property for MoleculePlatformModel #50

Merged
merged 1 commit into from
May 12, 2021
Merged

Add new property for MoleculePlatformModel #50

merged 1 commit into from
May 12, 2021

Conversation

egarbi
Copy link
Contributor
@egarbi egarbi commented May 12, 2021

Fixes #46

I used tox to generate the f/molecule.json file.
Although tests were failing, might be expected.

@egarbi egarbi requested a review from ssbarnea as a code owner May 12, 2021 13:25
@ssbarnea ssbarnea added the bug Something isn't working label May 12, 2021
@ssbarnea
Copy link
Member

@egarbi I think tests will be passing, probably you were missing ajv which is not automatically installed.

For the future, remind to also add or modify one sample file with the missing element, we use them to validate that the new schema works as expected. They are also used as fail-safe for other changes so we do not accidentally remove attributes which are supposed to be supported.

@ssbarnea ssbarnea merged commit e699a10 into ansible:main May 12, 2021
@egarbi
Copy link
Contributor Author
egarbi commented May 12, 2021

@egarbi I think tests will be passing, probably you were missing ajv which is not automatically installed.
For the future, remind to also add or modify one sample file with the missing element, we use them to validate that the new schema works as expected. They are also used as fail-safe for other changes so we do not accidentally remove attributes which are supposed to be supported.

Indeed tests are passed now after installing ajv
I will have examples in mind for the next time.
Thanks for your support

@egarbi egarbi deleted the add_new_property_for_MoleculePlatformModel branch May 12, 2021 14:18
@egarbi egarbi mentioned this pull request May 12, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups property missing on platforms for molecule schema
2 participants
@egarbi @ssbarnea
0