Fix various goroutine leaks and open file descriptor leak #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ensure exit for GetResults Introduce a way to close the quic connection (as opposed to closing the stream)
d7394b8 to
b18b8ad
Compare
shanemcd
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a lot of things, but the main problem was go routine leaks surrounding our pub/sub broker. I've made changes to make sure we are guaranteed to exit those goroutines when we shutdown a connection.
The other big change is that we explicitly close the quic connection after use (on the dialer side).
err = conn.(interface{ CloseConnection() error }).CloseConnection()conn.Close() only shuts down the write side of the quic stream. The underlying connection was hanging around, and with it lots of goroutines.
There might still be an avenue for connection leaks -- if the dialer closes a connection but the server never gets that close signal, then it might remain open indefinitely. We may need to find a way to auto-close a connection if it has been inactive for some period of time.