8000 Add test `work cancel` and `work release` by thenets · Pull Request #468 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add test work cancel and work release #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2021
Merged

Add test work cancel and work release #468

merged 4 commits into from
Nov 17, 2021

Conversation

thenets
Copy link
Member
@thenets thenets commented Nov 4, 2021 •
edited
Loading

DO NOT Fixes anymore #428

Many more fixtures were included or modified in order to support multiple meshes deployments.

Added two tests:

  • 🟢 test_work_unsigned
  • [disabled/commented] 🔴 test_work_signed_expect_block
    • This is failing, cause when the work submit fails, it doesn't return the work_unit_id.

@thenets thenets changed the base branch from devel to release_1.1 November 4, 2021 13:11
@thenets thenets force-pushed the receptorctl_test_work_verify_signature branch from 4f8e959 to 542d5ec Compare November 4, 2021 16:18
@thenets thenets mentioned this pull request Nov 4, 2021
Closed
@thenets thenets marked this pull request as ready for review November 4, 2021 16:25
@thenets
Full refactor from original pytest code finished
ae37a8e 
WIP receptorctl tests refactor

Clean up useless test content

Update Makefile receptorctl-tests command

Added hack to cli.py to allow pytest code

Remove hack from cli.py

Convert invoke commands to fixtures

WIP test_work_verify_signature

WIP add context

Remove test_mesh.py file

Fix all click lib problems with pytest

Minor sintax fix on Makefile
@thenets thenets changed the base branch from release_1.1 to devel November 17, 2021 06:26
@thenets thenets force-pushed the receptorctl_test_work_verify_signature branch from 542d5ec to 0c9a8b3 Compare November 17, 2021 06:27
@thenets
Copy link
Member Author
thenets commented Nov 17, 2021

@shanemcd @fosterseth hello! 😄

  • I removed the test_work_signed_expect_block until the fix be pushed to the receptor code base. I believe that we need to have a discussion in the future about merging broken tests. I can't understand why not merge a test that will break the pipeline, because the tests are made to raise those problems as soon as possible.

  • I also removed the receptorctl-lint. We can't have a blocker step in the pipeline without even having a discussion before that. Things like length are not configured for black and require manual "fixes", for example. We can enable this lint but in a dedicated PR, because the current state is causing more harm than helping.

Please, help me to review and merge this. I need this PR merge in order to add more test that requires multiple meshes.

@thenets thenets mentioned this pull request Nov 17, 2021
Merged
@shanemcd
Copy link
Member

@thenets The whole point of adding black is to remove the need for discussing code styles. To fix your code, just run black receptorctl.

@thenets
Copy link
Member Author
thenets commented Nov 17, 2021

@shanemcd doesn't work. You can clone the branch and try.

I agree that we should add this, but in a dedicated PR, without blocking existent test code.

@thenets
Add signed work tests
efd7a84 
WIP mesh

Add log file

Cleanup fixtures

Finally working! (the test. Receptorctl is failing)

Cleanup

After rebase fixes

Fx teardiown. It's being handled by the test by default

Add lint fixes
@thenets thenets force-pushed the receptorctl_test_work_verify_signature branch from aa82bf0 to c6b54c3 Compare November 17, 2021 09:12
@thenets
Disabled test_work_signed_expect_block
cf783d2 
The current repo setting do not allow merge broken pipeline, so
this test is being disabled until the code be fixed.

Lint fix

Fix fixture
@thenets
Remove test teardown from pipeline
364b09a
@thenets thenets force-pushed the receptorctl_test_work_verify_signature branch from c6b54c3 to 364b09a Compare November 17, 2021 09:21
@shanemcd shanemcd merged commit 8c7bac6 into ansible:devel Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd approved these changes

@fosterseth fosterseth Awaiting requested review from fosterseth

@amolgautam25 amolgautam25 Awaiting requested review from amolgautam25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thenets @shanemcd
0