Give receptor subprocess a nodeID #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fc7915 to
4c3c12f
Compare
shanemcd
approved these changes
Jan 10, 2022
When work units are started, a separate receptor process is ran If this receptor process does not have a node ID, receptor will try to use os.hostname. If hostname begins with "localhost", receptor will error out. To avoid this scenario, we should just give the receptor a nodeID. Since this receptor process is not joining a mesh, the name really doesn't matter.
4c3c12f to
687c96e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue #470
When work units are started, a separate receptor process is started to run the command (that way if the main receptor process goes down, we can still monitor whatever command is running, i.e. ansible-runner)
If this receptor process does not have a node ID, receptor will try to use os.hostname. If hostname begins with "localhost", receptor will error out, as "localhost" is a reserved keyword in receptor to mean "this node".
To avoid this scenario, we should just give the receptor a nodeID. Since this receptor process is not joining a mesh, the name really doesn't matter, so I just chose
worker. We could also give it the same name as the parent receptor node.