Cleanup error messages in log #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahhh
approved these changes
Jan 11, 2022
kdelee
approved these changes
Jan 19, 2022
- Suppress errors related to Normal close of quic connections - Change a few Info level messages to Debug, to reduce repetitive messages
0d11912 to
b391082
Compare
shanemcd
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #510
cleaned up some excessive error messages that would occur even under normal and expected situations.
CloseConnection() in conn.go returns an Error message (the normal way to close a quic connection is via a CloseWithError, see quic-go/quic-go#3270). Therefore, we should check to see if Write or Read attempts on a closed connection returns this normal error, and only log a message if it is not normal.
Also moved some of the more repetitive log messages from Info to Debug.