10000 Fix several race conditions and sources of test flake by fosterseth · Pull Request #547 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix several race conditions and sources of test flake #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 21, 2022
Merged

Fix several race conditions and sources of test flake #547

merged 14 commits into from
Feb 21, 2022

Conversation

fosterseth
Copy link
Member

Fixed up a few places in the code where we do blocking send and receive calls, but don't select on the overall context being finished.

This should help mitigate some race conditions we've discovered in testing when starting up and shutting down nodes.

@fosterseth fosterseth force-pushed the fix_neceptor_send_receive branch from a285de7 to 0a252fe Compare February 15, 2022 17:27
@shanemcd shanemcd mentioned this pull request Feb 15, 2022
Closed
@fosterseth fosterseth force-pushed the fix_neceptor_send_receive branch from 0a252fe to a5708d1 Compare February 15, 2022 17:46
@fosterseth fosterseth force-pushed the fix_neceptor_send_receive branch from fce5eed to 5147efb Compare February 16, 2022 14:41
@shanemcd
Copy link
Member

It looks like this is leaking a whoooole lot of goroutines. Going to clone this locally and see if I can find what's going on.

fosterseth and others added 13 commits February 20, 2022 12:14
@shanemcd shanemcd changed the title Fix netceptor send receive calls Fix several race conditions and sources of flake Feb 21, 2022
@shanemcd shanemcd changed the title Fix several race conditions and sources of flake Fix several race conditions and sources of test flake Feb 21, 2022
@shanemcd shanemcd merged commit a1be40a into ansible:devel Feb 21, 2022
@shanemcd shanemcd mentioned this pull request Feb 22, 2022
Closed
@fosterseth fosterseth mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghjm ghjm ghjm left review comments

@shanemcd shanemcd shanemcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fosterseth @shanemcd @ghjm
0