Add unit test for addr.go #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #1105 +/- ##
==========================================
+ Coverage 42.29% 42.98% +0.68%
==========================================
Files 44 47 +3
Lines 6850 7436 +586
==========================================
+ Hits 2897 3196 +299
- Misses 3710 3998 +288
+ Partials 243 242 -1
... and 8 files with indirect coverage changes
|
AaronH88
reviewed
Aug 2, 2024
pkg/netceptor/addr.go
Outdated
| network string | ||
| node string | ||
| service string | ||
| NetworkStr string |
There was a problem hiding this comment.
Great work on this, can you quickly run through why the vars need to be exported please?
There was a problem hiding this comment.
The vars need to be exported in order for netceptor_test to create an Addr with set vars for this test. The vars need to be set so that Network() and String() return values
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test for addr.go
Addr struct properties need to be public in order to create a test Addr struct outside of netceptor for this test.