8000 Add deprecation notice to code by thom-at-redhat · Pull Request #1101 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add deprecation notice to code #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2024
Merged

Add deprecation notice to code #1101

merged 4 commits into from
Jul 31, 2024

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link
codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.76%. Comparing base (99eead1) to head (cc52d36).
Report is 75 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/python.go 25.00% 3 Missing ⚠️ 
@@            Coverage Diff             @@
##            devel    #1101      +/-   ##
==========================================
+ Coverage   42.49%   42.76%   +0.26%     
==========================================
  Files          43       46       +3     
  Lines        6772     7354     +582     
==========================================
+ Hits         2878     3145     +267     
- Misses       3663     3975     +312     
- Partials      231      234       +3
Files with missing lines Coverage Δ
pkg/workceptor/python.go 8.82% <25.00%> (-0.56%) ⬇️

... and 7 files with indirect coverage changes

Components Coverage Δ
Go 42.20% <25.00%> (-0.30%) ⬇️
Receptorctl 49.31% <ø> (∅)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

AaronH88
AaronH88 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor
@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 1cffdce into ansible:devel Jul 31, 2024
23 of 24 checks passed
@thom-at-redhat thom-at-redhat deleted the add_deprecation_notice branch July 31, 2024 10:12
@tvo318 tvo318 mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronH88 AaronH88 AaronH88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thom-at-redhat @AaronH88
0