8000 Add test for kubeLoggingWithReconnect by matoval · Pull Request #1236 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add test for kubeLoggingWithReconnect #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 10, 2024
Merged

Add test for kubeLoggingWithReconnect #1236

merged 7 commits into from
Dec 10, 2024

Conversation

matoval
Copy link
Collaborator
@matoval matoval commented Dec 6, 2024

Add test for kubeLoggingWithReconnect

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link
codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.51%. Comparing base (31c861c) to head (6722915).
Report is 18 commits behind head on devel.

8000 Files with missing lines Patch % Lines
pkg/workceptor/kubernetes.go 54.54% 3 Missing and 2 partials ⚠️ 
@@            Coverage Diff             @@
##            devel    #1236      +/-   ##
==========================================
+ Coverage   40.17%   41.51%   +1.34%     
==========================================
  Files          45       48       +3     
  Lines        9275     9859     +584     
==========================================
+ Hits         3726     4093     +367     
- Misses       5272     5480     +208     
- Partials      277      286       +9
Files with missing lines Coverage Δ
pkg/workceptor/kubernetes.go 27.64% <54.54%> (+6.23%) ⬆️

... and 5 files with indirect coverage changes

Components Coverage Δ
Go 41.02% <54.54%> (+0.85%) ⬆️
Receptorctl 49.31% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matoval matoval marked this pull request as ready for review December 9, 2024 21:10
AaronH88
AaronH88 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor
@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 9192dc5 into ansible:devel Dec 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronH88 AaronH88 AaronH88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matoval @AaronH88
0