8000 Refactor how kubernetes.go reads the final lines of stdout by AaronH88 · Pull Request #1285 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor how kubernetes.go reads the final lines of stdout #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2025
Merged

Refactor how kubernetes.go reads the final lines of stdout #1285

merged 3 commits into from
Mar 24, 2025

Conversation

AaronH88
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link
codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.64%. Comparing base (81219c2) to head (9f7921b).
Report is 2 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/kubernetes.go 60.00% 5 Missing and 1 partial ⚠️ 
@@            Coverage Diff             @@
##            devel    #1285      +/-   ##
==========================================
+ Coverage   40.37%   40.64%   +0.26%     
==========================================
  Files          45       48       +3     
  Lines        9459    10054     +595     
==========================================
+ Hits         3819     4086     +267     
- Misses       5344     5673     +329     
+ Partials      296      295       -1
Files with missing lines Coverage Δ
pkg/workceptor/kubernetes.go 27.43% <60.00%> (-1.56%) ⬇️

... and 6 files with indirect coverage changes

Components Coverage Δ
Go 40.10% <60.00%> (-0.27%) ⬇️
Receptorctl 49.31% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AaronH88 AaronH88 marked this pull request as ready for review March 21, 2025 17:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues 0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matoval
matoval approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator
@matoval matoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit bdaf470 into ansible:devel Mar 24, 2025
24 checks passed
fincamd pushed a commit to fincamd/receptor that referenced this pull request Apr 1, 2025
@AaronH88 @fincamd
Refactor how kubernetes.go reads the final lines of stdout (ansible#1285
888248f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matoval matoval matoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronH88 @matoval
0