8000 Migrate mock generation to go generate by lranjbar · Pull Request #1297 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate mock generation to go generate #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Migrate mock generation to go generate #1297

wants to merge 1 commit into from

Conversation

lranjbar
Copy link
Contributor
@lranjbar lranjbar commented Apr 3, 2025 •
edited
Loading

Migrating the mock generation in receptor so all mocks can be generated using the command go generate ./... from the base directory.

@codecov Codecov
Copy link
codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.31%. Comparing base (784f362) to head (8b1a68e).

@@            Coverage Diff             @@
##            devel    #1297      +/-   ##
==========================================
+ Coverage   43.38%   49.31%   +5.92%     
==========================================
  Files          56        3      -53     
  Lines        9778      580    -9198     
==========================================
- Hits         4242      286    -3956     
+ Misses       5232      294    -4938     
+ Partials      304        0     -304

see 59 files with indirect coverage changes

Components Coverage Δ
Go ∅ <ø> (∅)
Receptorctl 49.31% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matoval
matoval reviewed Apr 8, 2025
View reviewed changes
matoval
matoval approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator
@matoval matoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

AaronH88
AaronH88 reviewed Apr 9, 2025
View reviewed changes
AaronH88
AaronH88 reviewed Apr 9, 2025
View reviewed changes
pkg/controlsvc/mock_controlsvc/io.go
@@ -1,84 +0,0 @@
// Code generated by MockGen. DO NOT EDIT.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

I love it when we can delete code

@lranjbar lranjbar force-pushed the git-generate-mocks branch 2 times, most recently from 17dcdae to 4ec85dc Compare April 18, 2025 00:06
@lranjbar lranjbar force-pushed the git-generate-mocks branch 2 times, most recently from 043e6ce to 8b1a68e Compare April 30, 2025 18:03
@lranjbar lranjbar force-pushed the git-generate-mocks branch from 8b1a68e to 6d1d552 Compare May 1, 2025 00:15
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronH88 AaronH88 AaronH88 left review comments

@matoval matoval matoval approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lranjbar @AaronH88 @matoval
0