8000 Fix flock_test from interrupting utils package tests by matoval · Pull Request #1314 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix flock_test from interrupting utils package tests #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matoval
Copy link
Collaborator
@matoval matoval commented Apr 28, 2025

Utils package unit tests are stopping after running flock_test because the test was unlocking FD 1 which is stdout.

This change fixes the test by creating a temp file and unlock it instead of FD 1.

Copy link
codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.23%. Comparing base (844a66d) to head (7035c6d).
Report is 2 commits behind head on devel.

@@            Coverage Diff             @@
##            devel    #1314      +/-   ##
==========================================
+ Coverage   41.52%   42.23%   +0.70%     
==========================================
  Files          45       59      +14     
  Lines        9459    10357     +898     
==========================================
+ Hits         3928     4374     +446     
- Misses       5237     5681     +444     
- Partials      294      302       +8     

see 18 files with indirect coverage changes

Components Coverage Δ
Go 41.81% <ø> (+0.28%) ⬆️
Receptorctl 49.31% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copy link
Contributor
@davemulford davemulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor
@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit c89aaed into ansible:devel Apr 30, 2025
24 checks passed
arrestle pushed a commit to arrestle/receptor that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0