8000 Remove unreachable code in workceptor/remote_work.go by lranjbar · Pull Request #1339 · ansible/receptor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unreachable code in workceptor/remote_work.go #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

lranjbar
Copy link
Contributor

The variable err is always nil here because it is checked against err != nil on lines 347-351 and returned.

There is not another function populating err here. I think there was a Save() function that was called in the past but this is no longer called.

Copy link

@lranjbar lranjbar marked this pull request as draft June 10, 2025 22:00
Copy link
codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.67%. Comparing base (8636a79) to head (8db02d4).
Report is 10 commits behind head on devel.

@@            Coverage Diff             @@
##            devel    #1339      +/-   ##
==========================================
+ Coverage   44.56%   44.67%   +0.10%     
==========================================
  Files          59       62       +3     
  Lines        9776    10351     +575     
==========================================
+ Hits         4357     4624     +267     
- Misses       5109     5412     +303     
- Partials      310      315       +5     
Files with missing lines Coverage Δ
pkg/workceptor/remote_work.go 10.89% <ø> (+0.09%) ⬆️

... and 7 files with indirect coverage changes

Components Coverage Δ
Go 44.39% <ø> (-0.18%) ⬇️
Receptorctl 49.31% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lranjbar lranjbar marked this pull request as ready for review June 21, 2025 02:02
Copy link
Contributor
@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator
@matoval matoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this check was left behind in a previous PR

@lranjbar lranjbar merged commit a8d2992 into ansible:devel Jun 23, 2025
24 of 26 checks passed
@lranjbar lranjbar deleted the workceptor-unreachable-code branch June 23, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0