FIX: Insert row fix for tables #5931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5931 +/- ##
==========================================
- Coverage 85.06% 85.06% -0.01%
==========================================
Files 166 166
Lines 62980 62980
==========================================
- Hits 53577 53574 -3
- Misses 9403 9406 +3 🚀 New features to boost your workflow:
|
myoung301
requested changes
Apr 3, 2025
tests/system/solvers/test_45_FilterSolutions/test_filter/test_transmission_zeros.py
Outdated
Show resolved
Hide resolved
tests/system/solvers/test_45_FilterSolutions/test_filter/test_transmission_zeros.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/filtersolutions_core/lumped_termination_impedance_table.py
8000
Outdated
Show resolved
Hide resolved
myoung301
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the insert functions to work properly.
Issue linked
The insert function behaves like an update function and does not shift the rows.
Checklist