REFACTOR: Improve code quality and handling of subprocess calls #5995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5995 +/- ##
==========================================
+ Coverage 85.07% 85.09% +0.02%
==========================================
Files 165 165
Lines 62892 62886 -6
==========================================
+ Hits 53505 53514 +9
+ Misses 9387 9372 -15 🚀 New features to boost your workflow:
|
Samuelopez-ansys
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve code quality, avoid bad practices and improve vulnerability risks associated to the use of
subprocess.Note that an static internal method has been removed as I though it was not used/leveraged.
@ansAFinney Part of the changes remove what you did in #4294. Indeed, launching the server and exposing it to all network interfaces is a security risk so it shouldn't be the default behavior. If you want to keep the previous behavior, this is possible using
the
AEDT_HOSTenvironment variable.Associated to #5504
Checklist