10000 REFACTOR: pathlib refactor primitives_circuit.py by anur7 · Pull Request #6024 · ansys/pyaedt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

REFACTOR: pathlib refactor primitives_circuit.py #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

REFACTOR: pathlib refactor primitives_circuit.py #6024

merged 4 commits into from
Apr 10, 2025

Conversation

anur7
Copy link
Contributor
@anur7 anur7 commented Apr 9, 2025

Description

Continuation of pathlib refactoring

Issue linked

Issue #5180

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@anur7 anur7 self-assigned this Apr 9, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 added enhancement New features or code improvements maintenance Package and maintenance related labels Apr 9, 2025
@anur7 anur7 marked this pull request as ready for review April 9, 2025 14:49
@codecov Codecov
Copy link
codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.08%. Comparing base (3da9057) to head (3fc05fc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6024      +/-   ##
==========================================
- Coverage   85.08%   85.08%   -0.01%     
==========================================
  Files         166      166              
  Lines       62978    62977       -1     
==========================================
- Hits        53587    53581       -6     
- Misses       9391     9396       +5
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gmalinve
gmalinve approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor
@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmalinve gmalinve merged commit 9095b51 into main Apr 10, 2025
43 checks passed
@gmalinve gmalinve deleted the refactor-pathlib-primitives_circuit branch April 10, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmalinve gmalinve gmalinve approved these changes

@jvela018 jvela018 Awaiting requested review from jvela018

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

@gkorompi gkorompi Awaiting requested review from gkorompi

Assignees

@anur7 anur7

Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anur7 @gmalinve @pyansys-ci-bot
0