8000 FIX: fix small bug in time domain report by maxcapodi78 · Pull Request #6126 · ansys/pyaedt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIX: fix small bug in time domain report #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025
Merged

FIX: fix small bug in time domain report #6126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d0ee5b3
fix small bug in time domain report
maxcapodi78 May 8, 2025
e8df826
chore: adding changelog file 6126.fixed.md [dependabot-skip]
pyansys-ci-bot May 8, 2025
7106b18
fix small bug in time domain report
maxcapodi78 May 8, 2025
d9d19cd
Merge remote-tracking branch 'origin/fix_time_domain_report' into fix…
maxcapodi78 May 8, 2025
af12432
Added fix for doc builder
maxcapodi78 May 8, 2025
549cfe1
Merge branch 'main' into fix_time_domain_report
Samuelopez-ansys May 8, 2025
019a7fb
Use new ansys sphinx
Samuelopez-ansys May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/6126.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix small bug in time domain report
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ dotnet = [
"pywin32>=303; platform_system=='Windows'",
]
doc = [
"ansys-sphinx-theme>=1.0.0,<1.4",
"ansys-sphinx-theme>=1.0.0,<1.5",
"jupyter",
"numpydoc>=1.5.0,<1.9",
"recommonmark",
Expand Down
2 changes: 1 addition & 1 deletion src/ansys/aedt/core/visualization/post/compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@
if pass_fail and not pass_fail_criteria:
if report_type in ["standard", "frequency", "time"]:
pass_fail_criteria = local_config.get("limitLines", None)
elif report_type.contains("eye"):
elif "eye" in report_type:

Check warning on line 1146 in src/ansys/aedt/core/visualization/post/compliance.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/aedt/core/visualization/post/compliance.py#L1146 

Added line #L1146 was not covered by tests
pass_fail_criteria = local_config.get("eye_mask", None)
if group and report_type in ["standard", "frequency", "time"]:
new_dict = {}
Expand Down
6 changes: 0 additions & 6 deletions src/ansys/aedt/core/visualization/report/standard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,12 +445,6 @@ def _context(self):
"WE",
False,
self.time_stop,
"WM",
False,
self.time_stop,
"WN",
False,
self.time_start,
"WS",
False,
self.time_start,
Expand Down
Loading
0