8000 FIX: improved ibis pin load time by maxcapodi78 · Pull Request #6181 · ansys/pyaedt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIX: improved ibis pin load time #6181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

FIX: improved ibis pin load time #6181

merged 3 commits into from
May 21, 2025

Conversation

maxcapodi78
Copy link
Collaborator

Description

Ibisreader was unecessarly reloading the file every buffer.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@maxcapodi78 maxcapodi78 requested a review from a team as a code owner May 21, 2025 11:17
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov Codecov
Copy link
codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (d97a29e) to head (e349d95).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6181      +/-   ##
==========================================
- Coverage   85.25%   85.24%   -0.01%     
==========================================
  Files         170      170              
  Lines       64100    64104       +4     
==========================================
- Hits        54647    54646       -1     
- Misses       9453     9458       +5
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) May 21, 2025 14:10
@maxcapodi78 maxcapodi78 merged commit cdd2e16 into main May 21, 2025
34 checks passed
@maxcapodi78 maxcapodi78 deleted the improve_ibis_load_time branch May 21, 2025 14:37
jsalant22 pushed a commit that referenced this pull request Jun 3, 2025
@maxcapodi78 @pyansys-ci-bot @jsalant22
FIX: improved ibis pin load time (#6181)
20174a9 
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcapodi78 @Samuelopez-ansys @pyansys-ci-bot
0