8000 Feat/static rom constraints by chrpetre · Pull Request #298 · ansys/pytwin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat/static rom constraints #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 5, 2025
Merged

Feat/static rom constraints #298

merged 16 commits into from
Jun 5, 2025

Conversation

chrpetre
Copy link
Collaborator
@chrpetre chrpetre commented Jun 4, 2025 •
edited
Loading
  • Add support for TBROM processing when constraints are enabled during the ROM building stage, including new unit test
  • Modify CI workflow so that documentation build step reports an error (red flag) whenever one of the example reports an error in the build_error.txt file. This has been tested to detect the latest error on Fluent example after build: bump ansys-fluent-core from 0.30.5 to 0.32.1 #295, as well as by manually disabling license server on the runner, which both cases reported successfully an error in the workflow
  • Revert some of the changes from build: bump ansys-fluent-core from 0.30.5 to 0.32.1 #295 as the ansys-fluent-core 0.32.1 leads to an error when executing the Fluent example for documentation

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New features or code improvements labels Jun 4, 2025
@codecov-commenter
Copy link
codecov-commenter commented Jun 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (a98ce11) to head (8c91437).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   83.82%   83.61%   -0.22%     
==========================================
  Files          14       14              
  Lines        2881     2911      +30     
==========================================
+ Hits         2415     2434      +19     
- Misses        466      477      +11
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 5, 2025
chrpetre added 4 commits June 5, 2025 11:25
@chrpetre
Update ci.yml
0552236
@chrpetre
Update ci.yml
1e251f6
@chrpetre
Update ci.yml
7bb671b
@chrpetre
resolving Fluent doc example issue
28d9ba8 
ansys-fluent-core 0.32.1 does not work for that example, restricting to <0.32
@github-actions github-actions bot added the dependencies Related with project dependencies label Jun 5, 2025
@chrpetre chrpetre mentioned this pull request Jun 5, 2025
Closed
@chrpetre chrpetre marked this pull request as ready for review June 5, 2025 13:26
@chrpetre chrpetre requested a review from lboucin June 5, 2025 13:26
lboucin
lboucin approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator
@lboucin lboucin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've made minor suggestions/verifications that can be completed in a further PR if this fix is urgent.

@chrpetre chrpetre merged commit 4bfb4e3 into main Jun 5, 2025
29 of 37 checks passed
@chrpetre chrpetre deleted the feat/static_rom_constraints branch June 5, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lboucin lboucin lboucin approved these changes

Assignees
No one assigned
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrpetre @codecov-commenter @lboucin
0