-
-
Notifications
You must be signed in to change notification settings - Fork 719
fix: resolve the security issues of apikey #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthrough本次更新统一了多个组件和文档示例中的 API 接口地址与密钥为占位符,并优化了流式消息解析和内容拼接逻辑,特别是对 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant Agent
participant API
User->>UI: 发送消息
UI->>Agent: 调用 agent.send
Agent->>API: 请求 /api/llm_siliconflow_deepseekv3 (带占位符密钥)
API-->>Agent: 流式返回 JSON 块
Agent->>UI: 提取 reasoning_content 和 content,拼接 <think> 标签
UI-->>User: 渲染处理后的消息内容
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses security concerns by updating API keys and URLs across several components. It also refines the message transformation logic to handle content more robustly. Changes
|
Bundle ReportChanges will decrease total bundle size by 466 bytes (-0.34%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antdx-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (2)
docs/playground/independent.tsx (1)
37-40
: 本地化类型定义,提高代码独立性将
BubbleDataType
类型从外部导入改为本地定义,这样可以减少对外部模块的依赖,使组件更加独立。但需要注意,新定义的类型与原导入类型的结构不完全相同,原类型继承自BubbleProps
并包含可选的key
和role
属性,而新类型仅包含必需的role
和content
字符串属性。建议确保这种类型变更不会影响其他依赖于此类型的代码逻辑。
docs/playground/copilot.tsx (1)
34-37
: 本地化类型定义,提高代码独立性将
BubbleDataType
类型从外部导入改为本地定义,这样可以减少对外部模块的依赖,使组件更加独立。但需要注意,新定义的类型与原导入类型的结构不完全相同,原类型继承自BubbleProps
并包含可选的key
和role
属性,而新类型仅包含必需的role
和content
字符串属性。建议确保这种类型变更不会影响其他依赖于此类型的代码逻辑。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
components/use-x-agent/demo/model.tsx
(2 hunks)components/use-x-chat/demo/model.tsx
(2 hunks)components/x-request/demo/model.tsx
(1 hunks)components/x-request/index.ts
(0 hunks)docs/playground/copilot.tsx
(5 hunks)docs/playground/independent.tsx
(7 hunks)
💤 Files with no reviewable changes (1)
- components/x-request/index.ts
🧰 Additional context used
🧬 Code Graph Analysis (2)
docs/playground/independent.tsx (1)
components/bubble/BubbleList.tsx (1)
BubbleDataType
(22-25)
docs/playground/copilot.tsx (1)
components/bubble/BubbleList.tsx (1)
BubbleDataType
(22-25)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build preview
- GitHub Check: test / react component workflow
- GitHub Check: size
🔇 Additional comments (7)
components/x-request/demo/model.tsx (1)
12-14
: 优化了API密钥安全性和端点配置代码更新了API端点、模型标识符和API密钥。这些更改符合PR的目标,通过 8000 用占位符替换了实际的API密钥,提高了安全性。
具体更改:
- 将基础URL从特定的API端点更改为通用的占位符URL
- 更新了模型到最新版本
- 用占位符替换了实际的API密钥
components/use-x-agent/demo/model.tsx (2)
13-13
: 增强了API密钥安全性代码修改了API端点和密钥配置,将实际的API密钥替换为占位符值,这符合PR目标中提到的解决API密钥安全问题。
Also applies to: 15-15
70-70
: 简化了流式内容的获取逻辑代码优化了从流式响应中提取内容的方式,不再显式检查
reasoning_content
,而是直接访问modalMessage?.choices?.[0]?.delta?.content
并提供空字符串作为回退值。这种更改使代码更简洁且更健壮。docs/playground/independent.tsx (2)
274-274
: 提高API密钥安全性代码更新了API端点并用占位符替换了实际的API密钥,符合PR的目标,解决了API密钥泄露的安全隐患。
Also applies to: 276-276
296-320
: 优化了流式消息处理逻辑重写了
transformMessage
函数来分别处理reasoning_content
和content
内容,通过条件逻辑来处理<think>
标签的包装,使得流式内容的拼接更加合理和健壮。新的实现能够正确处理以下情况:
- 原始消息内容为空且有新的思考内容时,添加
<think>
开始标签- 原始消息已包含
<think>
标签但尚未闭合,且有新的常规内容时,添加</think>
闭合标签- 其他情况下简单拼接内容
这种实现改进了流式响应的处理方式,使UI展示更加准确。
docs/playground/copilot.tsx (2)
178-178
: 提高API密钥安全性代码更新了API端点并用占位符替换了实际的API密钥,符合PR的目标,解决了API密钥泄露的安全隐患。
Also applies to: 180-180
200-224
: 优化了流式消息处理逻辑重写了
transformMessage
函数来分别处理reasoning_content
和content
内容,通过条件逻辑来处理<think>
标签的包装,使得流式内容的拼接更加合理和健壮。新的实现能够正确处理以下情况:
- 原始消息内容为空且有新的思考内容时,添加
<think>
开始标签- 原始消息已包含
<think>
标签但尚未闭合,且有新的常规内容时,添加</think>
闭合标签- 其他情况下简单拼接内容
这种实现改进了流式响应的处理方式,使UI展示更加准确。改动与
docs/playground/independent.tsx
文件中的更改保持一致,确保了代码库中处理流式消息的方式的一致性。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 66 66
Lines 1492 1492
Branches 388 405 +17
=======================================
Hits 1378 1378
Misses 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* chore: sync main to feature branch (#810) * fix(attachment): fix image display style (#751) * chore: update CodePreviewer to support React 19 (#758) * docs: update a new contributions charts (#761) * fix: fix some potential issue (#773) * refactor: using setState function (#774) Co-authored-by: vanndxh <wangyuezhou.wyz@digital-engine.com> * type: fix some potential issue (#775) * fix: watch config three sub-items (#777) * feat: function setState * fix: watch config --------- Co-authored-by: vanndxh <wangyuezhou.wyz@digital-engine.com> * fix: fix Conversations ellipsis tooltip issues by removing it (#776) * fix: fix Conversations ellipsis tooltip issues by removing it * test: update snapshot * style: use native text overflow style * docs: changelog of 1.2.0 (#778) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * 🏷️ type: add Conversation type export (#258) Co-authored-by: afc163 <afc163@gmail.com> * docs: fix the wrong docs of ThoughtChain (#781) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: fix the wrong docs of ThoughtChain * docs: optimize Bubble.List scoll position * docs: fix thought-chain and changelog * fix: Prompts scroll styles (#785) * fix: Prompts srollX * fix: Prompts srollX * docs: optimize Bubble.List scroll bar position (#783) * docs: optimize Bubble.List scoll position * docs: optimize Bubble.List scoll position * test: demo snap * fix: Prompts srollX * chore: sync main to feature branch --------- Co-authored-by: wzc520pyfm <1528857653@qq.com> Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Co-authored-by: Shinji-Li <1349021570@qq.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vanndxh <77873426+vanndxh@users.noreply.github.com> Co-authored-by: vanndxh <wangyuezhou.wyz@digital-engine.com> Co-authored-by: afc163 <afc163@gmail.com> * chore: fix warning of deprecated API (#827) * chore: fix warning of deprecated API * chore: fix ts * chore: fix logic * test: ignore legacy * chore: delete webpack.config.js (#229) * docs(bubble): update content and messageRender type (#814) * docs: sender supplement documents to address user inquiries (#835) * docs: supplement documents to address user inquiries * docs: sender * chore: sync main to feature branch * feat: make the Bubble foot and header to get from context & Bubble can get key (#683) * feat: 调整Bubble foot,header参数,支持头部获取上下文 * fix: # 支持useXAgent通过deps 获取最新状态 * fix: 剔多余提交 * fix: 英文文档格式修复 * fix 简化参数 * Update header-and-footer.tsx fix: 调整用例 * feat: bubble's footer and header * feat: bubble's footer and header * test: bubble's footer and header * fix: ts of key * fix: ts of key --------- Co-authored-by: Mickey <951203214@qq.com> * fix: resolve the security issues of apikey (#840) * fix: Resolve the security issues of apikey * fix: Resolve the security issues of apikey * test: update snap * fix:api key and stream * fix:api key and stream * docs: modification tips (#844) * docs: changelog of 1.3.0 (#845) * test: sender * test: delete * docs: changelog of 1.3.0 * docs: changelog of 1.3.0 * docs: changelog of 1.3.0 --------- Co-authored-by: wzc520pyfm <1528857653@qq.com> Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Co-authored-by: Shinji-Li <1349021570@qq.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vanndxh <77873426+vanndxh@users.noreply.github.com> Co-authored-by: vanndxh <wangyuezhou.wyz@digital-engine.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: 二货爱吃白萝卜 <smith3816@gmail.com> Co-authored-by: Lawliet <37376096+L-Hknu@users.noreply.github.com>
* fix: Resolve the security issues of apikey * fix: Resolve the security issues of apikey * test: update snap * fix:api key and stream * fix:api key and stream
🤔 This is a ...
🔗 Related Issues
#831
#790
Summary by CodeRabbit
<think>
标签包裹推理内容,实现推理内容与主内容的更细致流式展示。BubbleDataType
类型,替代原有的导入方式。