8000 Updates pause functionality by nnashwin · Pull Request #32 · antonmedv/countdown · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updates pause functionality #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree 8000 to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2023

Conversation

nnashwin
Copy link
Contributor
@nnashwin nnashwin commented Mar 5, 2023

Video of the feature working:
Screencast from 03-04-2023 04:43:03 PM.webm

TL Boright added 2 commits February 6, 2023 14:34
Adds pausing to the countdown timer by using the spacebar key.
Also added an input delay in order to avoid pausing happening
immediately when the space bar button is pressed.
Updates the pause functionality with the following:
1. Adds pause font in the lower 3/4 of the screen
2. Changes the button press to require a spacebar instead of 'p' and 'c'
3. Adds an input buffer timeout so you don't accidentally pause and
   unpause with one button press.
4. When unpausing, adds another call of the draw function so that the
   'Paused' text is immediately removed instead of waiting for the next
   tick.
@nnashwin nnashwin changed the title Add pause functionality Updates pause functionality Mar 5, 2023
@nnashwin
Copy link
Contributor Author
nnashwin commented Mar 5, 2023

Implements feature mentioned in this Issue:
#15

@antonmedv
Copy link
Owner

Nice!

@antonmedv antonmedv merged commit 10db737 into antonmedv:master Mar 5, 2023
@nnashwin nnashwin mentioned this pull request Mar 7, 2023
@nnashwin nnashwin deleted the add-pause-functionality branch March 7, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0