-
Notifications
You must be signed in to change notification settings - Fork 47
support concurrent add in ivf #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #780 +/- ##
==========================================
- Coverage 90.63% 90.13% -0.50%
==========================================
Files 218 222 +4
Lines 14444 14991 +547
==========================================
+ Hits 13091 13512 +421
- Misses 1353 1479 +126
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bugbot run |
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@@ -800,6 +800,9 @@ TestIVFConcurrentAdd(const fixtures::IVFTestIndexPtr& test_index, | |||
for (auto dim : resource->dims) { | |||
for (auto train_type : resource->train_types) { | |||
for (auto& [base_quantization_str, recall] : resource->test_cases) { | |||
if (base_quantization_str == "pqfs,fp16") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why skip this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pqfs doesn't support concurrent due the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package only used after build
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ BugBot reviewed your changes and found no bugs!
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@inabao cannot cherry-pick this pull request (conflict), please create a new request to branch 0.15 |
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
No description provided.