8000 support concurrent add in ivf by inabao · Pull Request #780 · antgroup/vsag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support concurrent add in ivf #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 30, 2025
Merged

support concurrent add in ivf #780

merged 10 commits into from
Jun 30, 2025

Conversation

inabao
Copy link
Collaborator
@inabao inabao commented May 30, 2025

No description provided.

@inabao inabao self-assigned this May 30, 2025
@inabao inabao added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label May 30, 2025
@inabao inabao requested a review from wxyucs as a code owner May 30, 2025 06:52
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 3, 2025
Copy link
codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   90.63%   90.13%   -0.50%     
==========================================
  Files         218      222       +4     
  Lines       14444    14991     +547     
==========================================
+ Hits        13091    13512     +421     
- Misses       1353     1479     +126     
Flag Coverage Δ
cpp 90.13% <88.37%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.73% <ø> (ø)
datacell 91.65% <100.00%> (-0.25%) ⬇️
index 88.26% <79.16%> (-0.12%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f94c1...5d2bdea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jiaweizone
Copy link
Collaborator

bugbot run

cursor[bot]

This comment was marked as outdated.

inabao added 7 commits June 26, 2025 20:24
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
modify
8000
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@@ -800,6 +800,9 @@ TestIVFConcurrentAdd(const fixtures::IVFTestIndexPtr& test_index,
for (auto dim : resource->dims) {
for (auto train_type : resource->train_types) {
for (auto& [base_quantization_str, recall] : resource->test_cases) {
if (base_quantization_str == "pqfs,fp16") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why skip this test

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pqfs doesn't support concurrent due the package

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package only used after build

inabao added 2 commits June 28, 2025 19:22
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@jiaweizone
Copy link
Collaborator

bugbot run

Copy link
@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Collaborator
@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator
@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator
@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inabao inabao merged commit 27a608c into main Jun 30, 2025
24 checks passed
@inabao inabao deleted the ivf-concurrent branch June 30, 2025 12:09
@wxyucs
Copy link
Collaborator
wxyucs commented Jul 1, 2025

@inabao cannot cherry-pick this pull request (conflict), please create a new request to branch 0.15

inabao added a commit that referenced this pull request Jul 1, 2025
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) module/testing size/L version/0.16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0