[attr_expression] update integer type to support uint64_t input #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ylj <lingyuan.ylj@antgroup.com> update integer type to support uint64_t input Signed-off-by: ylj <lingyuan.ylj@antgroup.com>
7421079 to
a6d6ce0
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 91.05% 91.17% +0.11%
==========================================
Files 221 221
Lines 14014 14178 +164
==========================================
+ Hits 12761 12927 +166
+ Misses 1253 1251 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
wxyucs
approved these changes
Jul 4, 2025
Comment on lines
+42
to
+46
| if (auto i64 = std::dynamic_pointer_cast<const IntListConstant<int64_t>>(list_expr->values)) { | ||
| list_variant = i64; | ||
| } else if (auto u64 = | ||
| std::dynamic_pointer_cast<const IntListConstant<uint64_t>>(list_expr->values)) { | ||
| list_variant = u64; |
There was a problem hiding this comment.
@yulijunzj i64, u64 seems to be a highlight keyword, rename in next pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.