8000 fix compile error in functests by inabao · Pull Request #857 · antgroup/vsag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix compile error in functests #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

fix compile error in functests #857

merged 3 commits into from
Jun 30, 2025

Conversation

inabao
Copy link
Collaborator
@inabao inabao commented Jun 27, 2025

close: #856

inabao added 2 commits June 27, 2025 17:30
@inabao
modify
7eb8844 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
modify
0941acc 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao inabao self-assigned this Jun 27, 2025
@inabao inabao requested review from wxyucs and jiaweizone as code owners June 27, 2025 09:32
@inabao inabao changed the title fix compile error in test_ivf fix compile error in functests Jun 27, 2025
LHT129
LHT129 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator
@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inabao
modify
d9934c3 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
8000
wxyucs
wxyucs approved these changes Jun 28, 2025
View reviewed changes
Copy link
Collaborator
@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wxyucs wxyucs added the kind/bug Something isn't working label Jun 28, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   90.63%   90.60%   -0.03%     
==========================================
  Files         218      222       +4     
  Lines       14444    14972     +528     
==========================================
+ Hits        13091    13566     +475     
- Misses       1353     1406      +53
Flag Coverage Δ
cpp 90.60% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.83% <ø> (+0.09%) ⬆️
datacell 91.67% <ø> (-0.23%) ⬇️
index 88.57% <ø> (+0.18%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f94c1...d9934c3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@inabao inabao merged commit e73dedf into main Jun 30, 2025
23 checks passed
@inabao inabao deleted the fix-bug-compile-error branch June 30, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxyucs wxyucs wxyucs approved these changes

@LHT129 LHT129 LHT129 approved these changes

@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

Assignees

@inabao inabao

Labels
kind/bug Something isn't working module/testing size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile error in test_ivf
3 participants
@inabao @wxyucs @LHT129
0