refactor cmake #870
Open
refactor cmake #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e6c58e to
1d4319d
Compare
inabao
reviewed
Jul 1, 2025
| @@ -17,7 +17,19 @@ | |||
|
|
|||
| #include <fmt/format.h> | |||
|
|
|||
| #include "../../logger.h" | |||
There was a problem hiding this comment.
can directly #include "logger.h" here?
There was a problem hiding this comment.
same name as diskann's logger.h
| template class StandardHeap<false, true>; | ||
| template class StandardHeap<false, false>; | ||
|
|
||
| } // namespace vsag |
| @@ -78,4 +78,4 @@ simd_add_definitions (DIST_CONTAINS_AVX512VPOPCNTDQ -DENABLE_AVX512VPOPCNTDQ=1) | |||
| simd_add_definitions (DIST_CONTAINS_NEON -DENABLE_NEON=1) | |||
|
|
|||
| target_link_libraries (simd INTERFACE cpuinfo coverage_config) | |||
| install (TARGETS simd ARCHIVE DESTINATION lib) | |||
| # install (TARGETS simd ARCHIVE DESTINATION lib) | |||
61a99a2 to
90ccf21
Compare
0227f2f to
7ac494b
Compare
ShawnShawnYou
approved these changes
Jul 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Your project check has failed because the head coverage (88.38%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #870 +/- ##
==========================================
- Coverage 90.25% 88.38% -1.87%
==========================================
Files 224 142 -82
Lines 15026 6894 -8132
==========================================
- Hits 13561 6093 -7468
+ Misses 1465 801 -664
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dc4ec85 to
99fcec4
Compare
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed: #886