8000 fix recall when using residual by inabao · Pull Request #874 · antgroup/vsag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix recall when using residual #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 4, 2025
Merged

fix recall when using residual #874

merged 8 commits into from
Jul 4, 2025

Conversation

inabao
Copy link
Collaborator
@inabao inabao commented Jul 1, 2025

fixed: #845

inabao added 2 commits July 2, 2025 00:58
@inabao
fix recall when gno-imi using residual
0e84194 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
modify
b64b859 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao inabao requested a review from LHT129 July 1, 2025 17:02
@inabao inabao self-assigned this Jul 1, 2025
@inabao inabao requested review from wxyucs and jiaweizone as code owners July 1, 2025 17:02
@inabao inabao added kind/bug Something isn't working version/0.16 labels Jul 1, 2025
@codecov Codecov
Copy link
codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (43.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (89.90%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   90.18%   89.90%   -0.28%     
==========================================
  Files         224      224              
  Lines       15004    15039      +35     
==========================================
- Hits        13531    13521      -10     
- Misses       1473     1518      +45
Flag Coverage Δ
cpp 89.90% <43.75%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.73% <ø> (ø)
datacell 90.44% <ø> (+0.27%) ⬆️
index 88.37% <43.75%> (-0.07%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f035ba...44ced01. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

inabao added 4 commits July 2, 2025 17:20
@inabao
modify
3439414 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
modify
13ee6e3 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
modify
7f2374e 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
modify
2e60c85 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao inabao changed the title fix recall when gno-imi using residual fix recall when using residual Jul 3, 2025
LHT129
LHT129 approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator
@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wxyucs
wxyucs reviewed Jul 3, 2025
View reviewed changes
tests/test_ivf.cpp

for (auto metric_type : resource->metric_types) {
for (auto dim : resource->dims) {
for (auto train_type : resource->train_types) {
for (auto& [base_quantization_str, recall] : tmp_test_cases) {
for (auto& [base_quantization_str, recall] : resource->test_cases) {
if (base_quantization_str == "sq8_uniform,fp32") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment about why need to skip this case

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

inabao added 2 commits July 4, 2025 11:07
@inabao
modify
3d4adb7 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
modify
44ced01 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 4, 2025
wxyucs
wxyucs approved these changes Jul 4, 2025
View reviewed changes
Copy link
Collaborator
@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inabao inabao merged commit b3baa79 into main Jul 4, 2025
21 of 23 checks passed
@inabao inabao deleted the fix-gno-imi-residual branch July 4, 2025 06:56
jingyueob pushed a commit to jingyueob/vsag that referenced this pull request Jul 15, 2025
@inabao @jingyueob
fix recall when using residual (antgroup#874)
94a34a0 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jingyue.zjl <jingyue.zjl@oceanbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxyucs wxyucs wxyucs approved these changes

@LHT129 LHT129 LHT129 approved these changes

@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

Assignees

@inabao inabao

Labels
kind/bug Something isn't working module/testing size/L version/0.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sq8 with IMI and residual have low recall rate problem
3 participants
@inabao @wxyucs @LHT129
0