8000 support use old serial format by wxyucs · Pull Request #878 · antgroup/vsag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support use old serial format #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Conversation

wxyucs
Copy link
Collaborator
@wxyucs wxyucs commented Jul 2, 2025

To support some special scenarios, like production cluster upgrades, we allow users to control the serial format via the index parameter.

@wxyucs wxyucs force-pushed the support-use-old-serial-format branch from a371957 to 2cff6d2 Compare July 2, 2025 12:35
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
@wxyucs wxyucs force-pushed the support-use-old-serial-format branch from 2cff6d2 to 412b0f0 Compare July 2, 2025 12:47
Copy link
codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (40.90%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             0.15     #878      +/-   ##
==========================================
- Coverage   90.50%   90.47%   -0.04%     
==========================================
  Files         218      218              
  Lines       14456    14492      +36     
==========================================
+ Hits        13084    13112      +28     
- Misses       1372     1380       +8     
Flag Coverage Δ
cpp 90.47% <40.90%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.73% <ø> (ø)
datacell 91.86% <ø> (+0.39%) ⬆️
index 88.09% <62.16%> (-0.26%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb8fa3...412b0f0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wxyucs wxyucs added version/0.15 kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) labels Jul 3, 2025
@wxyucs wxyucs self-assigned this Jul 3, 2025
@wxyucs wxyucs marked this pull request as ready for review July 3, 2025 11:58
Copy link
Collaborator
@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator
@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs merged commit b69e8af into 0.15 Jul 4, 2025
28 of 30 checks passed
@wxyucs wxyucs deleted the support-use-old-serial-format branch July 4, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/M version/0.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0