8000 fix antlr4 compilation issue by yulijunzj · Pull Request #888 · antgroup/vsag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix antlr4 compilation issue #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

yulijunzj
Copy link
Collaborator
@yulijunzj yulijunzj commented Jul 4, 2025

closed: #887
fix the compilation issue which is caused by undefined references to ANTLR4 library functions

…ANTLR4 library functions

Signed-off-by: ylj <lingyuan.ylj@antgroup.com>
@yulijunzj yulijunzj changed the title fix the compilation issue fixes #887 Jul 4, 2025
@yulijunzj yulijunzj changed the title fixes #887 fix antlr4 compilation issue Jul 4, 2025
Copy link
codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   90.17%   90.01%   -0.16%     
==========================================
  Files         224      224              
  Lines       15026    15026              
==========================================
- Hits        13549    13525      -24     
- Misses       1477     1501      +24     
Flag Coverage Δ
cpp 90.01% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.73% <ø> (ø)
datacell 90.88% <ø> (-0.56%) ⬇️
index 88.36% <ø> (-0.06%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0174e...8472283. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wxyucs wxyucs added the kind/bug Something isn't worki 8000 ng label Jul 4, 2025
Copy link
Collaborator
@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator
@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 661a487 into antgroup:main Jul 4, 2025
23 checks passed
wxyucs pushed a commit that referenced this pull request Jul 4, 2025
…ANTLR4 library functions (#888)

Signed-off-by: ylj <lingyuan.ylj@antgroup.com>
jingyueob pushed a commit to jingyueob/vsag that referenced this pull request Jul 15, 2025
…ANTLR4 library functions (antgroup#888)

Signed-off-by: ylj <lingyuan.ylj@antgroup.com>
Signed-off-by: jingyue.zjl <jingyue.zjl@oceanbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a compilation issue caused by undefined references to ANTLR4
3 participants
0