8000 Fix timezone handling in tender offer participation by devin-ai-integration[bot] · Pull Request #343 · antiwork/flexile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix timezone handling in tender offer participation #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Fix timezone handling in tender offer participation #343

merged 1 commit into from
May 31, 2025
+8 −6

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix timezone handling in tender offer participation

Problem

Users were unable to participate in tender offers (buybacks) due to timezone inconsistencies between frontend and backend date comparisons. The isFuture function on the frontend compared dates against local browser time, while the backend used server timezone, causing tender offers to appear closed on the frontend but open on the backend (or vice versa).

Solution

  • Frontend: Updated isFuture and isPast checks in tender offer page to use UTC with utc() wrapper
  • tRPC validation: Modified date comparisons in bid creation/deletion to use UTC consistently
  • Backend: Explicitly use UTC in TenderOffer#open? method with Time.current.utc

Changes

  • frontend/app/equity/tender_offers/[id]/page.tsx: Use UTC for tender offer open/closed status check
  • frontend/trpc/routes/tenderOffers/bids.ts: Use UTC for date range validation in bid operations
  • backend/app/models/tender_offer.rb: Explicitly use UTC in open? method

Testing

  • Lint checks passed successfully
  • Changes ensure consistent timezone handling across the entire tender offer system
  • Follows existing UTC pattern established in formatServerDate utility

Link to Devin run

https://app.devin.ai/sessions/adf2377cad0049529110c91ed7ef87d6

Requested by: sahil.lavingia@gmail.com

@devin-ai-integration @slavingia
Fix timezone handling in tender offer participation
fe40778 
- Use UTC for consistent date comparisons in isFuture/isPast checks
- Update tRPC validation to use UTC for tender offer date ranges
- Ensure backend uses UTC explicitly in Time.current comparison
- Fixes issue where tender offers appeared closed/open inconsistently based on user timezone

Co-Authored-By: sahil.lavingia@gmail.com <sahil.lavingia@gmail.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Original prompt from sahil.lavingia@gmail.com:

Received message in Slack channel #flexile:

@Devin update buyback code so that ppl can still participate: Assuming the issue is the end date timezone as I suggested below, setting `TenderOffer#ends_at` to tomorrow could be a temporary fix. But I suspect the real issue is here (see link), and that `isFuture` assumes the date is in UTC. (Nice to have Flexile open sourced for this purpose! I'd test &amp; PR a change but am running around most of today.) <https://github.com/antiwork/flexile/blob/main/frontend/app/equity/tender_offers/%5Bid%5D/page.tsx#L42|https://github.com/antiwork/flexile/blob/main/frontend/app/equity/tender_offers/%5Bid%5D/page.tsx#L42>

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 31, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

cursor-com[bot]
cursor-com bot reviewed May 31, 2025
View reviewed changes
Copy link
@cursor-com cursor-com bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!

Was this report helpful? Give feedback by reacting with 👍 or 👎

@slavingia slavingia merged commit f9af0f1 into main May 31, 2025
7 checks passed
@slavingia slavingia deleted the devin/1748697050-fix-tender-offer-timezone branch May 31, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor-com cursor-com[bot] cursor-com[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slavingia
0