Fixe age-default-recipient type to allow for multiple file names
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I got warnings when using the new `setopt` macro in Emacs to set e.g.
```
(setopt age-default-recipient
'("~/.ssh/age_yubikey.pub"
"~/.ssh/age_recovery.pub"))
```
because the value is not a filename, even though that's what the old type
expected. Therefore I added a `repeat file` as an optional additional allowed
type via `choice`.
anticomputer
added a commit
that referenced
this pull request
Apr 10, 2024
Set composite types for customizable variables that require it.
anticomputer
added a commit
that referenced
this pull request
Apr 10, 2024
anticomputer
added a commit
that referenced
this pull request
Apr 10, 2024
|
Addressed more comprehensively in https://github.com/anticomputer/age.el/releases/tag/v0.1.5 The PR is appreciated but just as a note you'll generally want to make sure you only file a PR for the changes you're actually targeting and not a bunch of indentation changes as well :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I got warnings when using the new
setoptmacro in Emacs to set e.g.because the value is not a filename, even though that's what the old type expected. Therefore I added a
repeat fileas an optional additional allowed type viachoice.