Make docker builder optional, and simplify local test step #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133854c to
446aa17
Compare
b209f31 to
f1e1fc4
Compare
…f accessing shell ENV in action
0c8578d to
4ff0ee3
Compare
…st has different env (libc, etc.)
8000
marshtompsxd
reviewed
May 5, 2025
…ted if this remote build path is messed up
marshtompsxd
reviewed
May 5, 2025
There was a problem hiding this comment.
What are these changes for?
There was a problem hiding this comment.
oh I just realized that each task in the previous version of CI does not skip installing the rust toolchain even if it's based on build-verus. Is that the problem?
There was a problem hiding this comment.
Yes, I cached Rust toolchain together with Verus, then it's unnecessary.
|
I don't understand why you name it as "Deprecate docker builder...". I think you are still using the docker builder, no? Please correct me if my understanding is wrong. |
Yes I forgot to update the title...it's now completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes test workflow easier to run locally.
Changes:
local-test.shwith support for local buildsbuild.mdThe reason I want to deprecate the docker builder is
vargodoes not reuse cache and include some changes in built binary each run (even with identical source), and that causes docker to build a new image from start, which requires a new builder image. The problem is worse with vdeployment controller, which depends on vreplicaset controller, and result in 4 fresh-built docker images ((vd+vrs) * (builder+controller)) per run locally. This quickly eats up my disk and time and I have to rundocker pruneevery time. For cases where builder is required (different runtime environment between host and controller base image), builder can still be used. Detailed usage is inbuild.md.