GO-4969: REST API Stage 2 #2303

jmetrikat · 2025-04-06T16:55:24Z

New Endpoints

Add new space endpoint: PATCH("/spaces/:space_id")
Add new type endpoints:
- POST("/spaces/:space_id/types")
- PATCH("/spaces/:space_id/types/:type_id")
- DELETE("/spaces/:space_id/types/:type_id")
Add new property endpoints:
- GET("/spaces/:space_id/properties")
- GET("/spaces/:space_id/properties/:property_id")
- POST("/spaces/:space_id/properties")
- PATCH("/spaces/:space_id/properties/:property_id")
- DELETE("/spaces/:space_id/properties/:property_id")
Add new tag endoints:
- ⁠GET("/spaces/:space_id/properties/:property_id/tags")
- ⁠GET("/spaces/:space_id/properties/:property_id/tags/:tag_id")
- ⁠POST("/spaces/:space_id/properties/:property_id/tags")
- ⁠PATCH("/spaces/:space_id/properties/:property_id/tags/:tag_id")
- ⁠DELETE("/spaces/:space_id/properties/:property_id/tags/:tag_id")

Improvements and Fixes

Add "Anytype-Version" header parameter to swagger spec
Add operation IDs to all endpoints in swagger spec
Add actual property id alongside already returned key
Return linked properties (featured and from sidebar) and plural_name for types
Introduce oneOf for Icon, PropertyWithValue and PropertyLinkWithValue in swagger spec

Breaking Changes

Rename recommended_layout to layout for types
Move description and source to []properties in CreateObjectRequest
Rename layout todo to action for consistency
Remove ot- prefix for type keys
Rename property to property_key in sort options in search
Deprecate separate markdown export, unify with getObject
Deprecate blocks in getObject in favor of markdown exported body (proper json block export will be added later)

github-actions · 2025-04-06T17:10:34Z

New Coverage	50.0% of statements
Patch Coverage	33.7% of changed statements (597/1774)

^{Coverage provided by https://github.com/seriousben/go-patch-cover-action}

…rchlist

…sting

…rchlist

…ord handling

…rchlist

…y retrieval

go-4969-rest-api-stage-2

Copilot

Pull Request Overview

This PR implements "GO-4969: REST API Stage 2" by removing the legacy internal API endpoints and introducing a new set of REST endpoints under the handler package. Key changes include the complete removal of internal list, export, and auth packages and the addition of new endpoints for types, templates, tags, spaces, properties, objects, search, members, and list management.

Reviewed Changes

Copilot reviewed 79 out of 79 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
core/api/internal/list/model.go	Removed legacy list model definitions.
core/api/internal/list/handler.go	Removed legacy list handlers.
core/api/internal/export/model.go and handler.go	Removed legacy export endpoints.
core/api/internal/auth/model.go and handler.go	Removed legacy authentication endpoints.
core/api/handler/*.go (type.go, template.go, tag.go, space.go, search.go, property.go, object.go, member.go, list.go, auth.go)	Introduced new endpoints with updated Swagger annotations and restructured API handlers.
core/api/core/mock_apicore/mock_ClientCommands.go	Updated mocks to support the new object type, relation, and option endpoint methods.
core/api/core/core.go	Updated the interface to include new methods for object types, relations, and tag options.

…etail handling

github-actions · 2025-05-05T23:02:53Z

	🔴 SMOKE-TEST FAILED
Tests	✔️ 19 tests run
Summary	🔴 17 failed; 🟢 2 passed; 🟡 0 skipped
Duration	🕐 23 minutes, 55 seconds
Testomat.io Report	📊 Run #88937538
Job	🗂️ Smoke Tests / smoke-test
Operating System	🖥️ `Linux` X64

✅ Passed Tests (2)

Revoking an invite link (51 seconds) Passed on retry: 2
Sync on staging nodes (1 minute, 19 seconds)

🟥 Failures (17)

🔴 Revoking an invite link

################[ Steps ]################
Given the server "default" 1 is running (141652.43ms)
And the user 1 is using client 1 (0.75ms)
And the user creates a new account on "staging" (1828.81ms)
And the account is synced within 60 seconds (62080.52ms)
Given the user has shared his space and generated an invite link (0.00ms)
When the user revokes the invite link (0.00ms)
Then the invite link should be invalid (0.00ms)
And the account is deleted (0.00ms)
And the server 1 is stopped (0.00ms)

🔴 User cancels their join request

################[ Steps ]################
Given the server "default" 1 is running (3389.12ms)
And the user 1 is using client 1 (0.34ms)
And the user creates a new account on "staging" (1794.47ms)
And the account is synced within 60 seconds (44200.57ms)
Given the user creates an object 1 in the account (8.81ms)
And the user can open the object 1 (10009.33ms)
And the user has shared his space and generated an invite link (1319.89ms)
And the account is synced within 60 seconds (100.70ms)
And the server "default" 2 is running (3425.93ms)
And the user 2 is using client 2 (0.30ms)
And the user creates a new account on "staging" (1827.48ms)
And the user sends requests to join the space (5001.97ms)
And the user cancels their join request (0.00ms)
And the user 1 is using client 1 (0.00ms)
Then there is no request pending for joining the space (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 User cancels their join request (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3445.12ms)
And the user 1 is using client 1 (0.27ms)
And the user creates a new account on "staging" (1799.16ms)
And the account is synced within 60 seconds (44224.18ms)
Given the user creates an object 1 in the account (7.95ms)
And the user can open the object 1 (10008.53ms)
And the user has shared his space and generated an invite link (1398.40ms)
And the account is synced within 60 seconds (100.56ms)
And the server "default" 2 is running (3446.15ms)
And the user 2 is using client 2 (0.25ms)
And the user creates a new account on "staging" (1819.15ms)
And the user sends requests to join the space (5001.29ms)
And the user cancels their join request (0.00ms)
And the user 1 is using client 1 (0.00ms)
Then there is no request pending for joining the space (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 User deletes the space and rejoins later

################[ Steps ]################
Given the server "default" 1 is running (3444.83ms)
And the user 1 is using client 1 (0.25ms)
And the user creates a new account on "staging" (1835.67ms)
And the account is synced within 60 seconds (62021.92ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Viewer" rights (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user 2 leaves the shared space (0.00ms)
And the user sends requests to join the space (0.00ms)
Then the request is automatically approved as "Viewer" again (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 User deletes the space and rejoins later (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3576.56ms)
And the user 1 is using client 1 (0.22ms)
And the user creates a new account on "staging" (1830.57ms)
And the account is synced within 60 seconds (62043.89ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Viewer" rights (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user 2 leaves the shared space (0.00ms)
And the user sends requests to join the space (0.00ms)
Then the request is automatically approved as "Viewer" again (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner changes the rights of a user from Viewer to Editor

################[ Steps ]################
Given the server "default" 1 is running (3603.14ms)
And the user 1 is using client 1 (0.23ms)
And the user creates a new account on "staging" (1809.52ms)
And the account is synced within 60 seconds (44214.77ms)
Given the user creates an object 1 in the account (8.49ms)
And the user can open the object 1 (10005.67ms)
And the user has shared his space and generated an invite link (1300.60ms)
And the account is synced within 60 seconds (100.58ms)
And the server "default" 2 is running (3480.04ms)
And the user 2 is using client 2 (0.23ms)
And the user creates a new account on "staging" (1830.81ms)
And the user sends requests to join the space (5001.03ms)
When the user 1 approves the join request of user 2 with "Viewer" rights (0.00ms)
And the user 1 changes the rights of user 2 from "Viewer" to "Editor" (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can open the object 1 (0.00ms)
And the user can rename the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner changes the rights of a user from Viewer to Editor (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3541.00ms)
And the user 1 is using client 1 (0.25ms)
And the user creates a new account on "staging" (1825.30ms)
And the account is synced within 60 seconds (62114.58ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Viewer" rights (0.00ms)
And the user 1 changes the rights of user 2 from "Viewer" to "Editor" (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can open the object 1 (0.00ms)
And the user can rename the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner approves a join request with Editor permissions

################[ Steps ]################
Given the server "default" 1 is running (3553.50ms)
And the user 1 is using client 1 (0.20ms)
And the user creates a new account on "staging" (1849.30ms)
And the account is synced within 60 seconds (62106.90ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Editor" rights (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can open the object 1 (0.00ms)
And the user can rename the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner approves a join request with Editor permissions (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3583.80ms)
And the user 1 is using client 1 (0.22ms)
And the user creates a new account on "staging" (1826.00ms)
And the account is synced within 60 seconds (62082.57ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Editor" rights (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can open the object 1 (0.00ms)
And the user can rename the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner declines a join request

################[ Steps ]################
Given the server "default" 1 is running (3578.02ms)
And the user 1 is using client 1 (0.26ms)
And the user creates a new account on "staging" (1835.72ms)
And the account is synced within 60 seconds (62105.93ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 declines the join request of user 2 (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can't open the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner declines a join request (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3578.86ms)
And the user 1 is using client 1 (0.14ms)
And the user creates a new account on "staging" (1846.91ms)
And the account is synced within 60 seconds (44227.58ms)
Given the user creates an object 1 in the account (7.88ms)
And the user can open the object 1 (10005.76ms)
And the user has shared his space and generated an invite link (1358.04ms)
And the account is synced within 60 seconds (99.93ms)
And the server "default" 2 is running (3575.45ms)
And the user 2 is using client 2 (0.24ms)
And the user creates a new account on "staging" (1832.79ms)
And the user sends requests to join the space (4999.86ms)
When the user 1 declines the join request of user 2 (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can't open the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner removes a participant from the space

################[ Steps ]################
Given the server "default" 1 is running (3490.80ms)
And the user 1 is using client 1 (0.22ms)
And the user creates a new account on "staging" (1856.16ms)
And the account is synced within 60 seconds (62116.94ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Editor" rights (0.00ms)
When the user 1 removes the user 2 from the space (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can't open the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner removes a participant from the space (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3669.13ms)
And the user 1 is using client 1 (0.18ms)
And the user creates a new account on "staging" (2053.24ms)
And the account is synced within 60 seconds (62028.13ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Editor" rights (0.00ms)
When the user 1 removes the user 2 from the space (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can't open the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner deletes a space

################[ Steps ]################
Given the server "default" 1 is running (3587.18ms)
And the user 1 is using client 1 (0.22ms)
And the user creates a new account on "staging" (1891.69ms)
And the account is synced within 60 seconds (62052.90ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Editor" rights (0.00ms)
And the user 1 deletes the shared space (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can't open the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner deletes a space (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3568.72ms)
And the user 1 is using client 1 (0.19ms)
And the user creates a new account on "staging" (2025.12ms)
And the account is synced within 60 seconds (62102.94ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Editor" rights (0.00ms)
And the user 1 deletes the shared space (0.00ms)
And the user 2 is using client 2 (0.00ms)
Then the user can't open the object 1 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner approves leave request

################[ Steps ]################
Given the server "default" 1 is running (3552.34ms)
And the user 1 is using client 1 (0.19ms)
And the user creates a new account on "staging" (1806.56ms)
And the account is synced within 60 seconds (62063.74ms)
Given the user creates an object 1 in the account (0.00ms)
And the user can open the object 1 (0.00ms)
And the user has shared his space and generated an invite link (0.00ms)
And the account is synced within 60 seconds (0.00ms)
And the server "default" 2 is running (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user creates a new account on "staging" (0.00ms)
And the user sends requests to join the space (0.00ms)
When the user 1 approves the join request of user 2 with "Viewer" rights (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user 2 leaves the shared space (0.00ms)
And the user 1 approves the leave request of user 2 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

🔴 Owner approves leave request (Will be retried 🔄)

################[ Steps ]################
Given the server "default" 1 is running (3577.19ms)
And the user 1 is using client 1 (0.18ms)
And the user creates a new account on "staging" (1851.01ms)
And the account is synced within 60 seconds (44171.38ms)
Given the user creates an object 1 in the account (9.32ms)
And the user can open the object 1 (10006.05ms)
And the user has shared his space and generated an invite link (1257.22ms)
And the account is synced within 60 seconds (100.62ms)
And the server "default" 2 is running (3600.68ms)
And the user 2 is using client 2 (0.22ms)
And the user creates a new account on "staging" (1883.33ms)
And the user sends requests to join the space (5000.85ms)
When the user 1 approves the join request of user 2 with "Viewer" rights (0.00ms)
And the user 2 is using client 2 (0.00ms)
And the user 2 leaves the shared space (0.00ms)
And the user 1 approves the leave request of user 2 (0.00ms)
And both accounts are deleted (0.00ms)
And both servers are stopped (0.00ms)

…ists

…rch through util

…error-handling GO-5591: Full-text: add missing error handling

…nces

…d GetTemplate

…edia etc.

jmetrikat added 2 commits April 6, 2025 18:18

GO-4969: Add disabled UpdateMemberHandler

0613021

GO-4969: Add Anytype-Version header parameter to API endpoints

2457779

jmetrikat and others added 27 commits April 6, 2025 20:38

GO-4969: Fix GET operations cannot have a requestBody

ef9562f

GO-4969 Merge branch 'main' into go-4969-rest-api-stage-2

9756b1e

GO-5428 api: do not use objectOpen, draft

b41c968

GO-5428: Refactor type, object and property helper

6efeb7d

GO-5428 Merge branch 'main' into go-5428-api-remove-objectopen-on-sea…

14689f3

…rchlist

8000

GO-5428: Refactor api internal service interfaces

ad2ba58

GO-5428: Optimize object creation from struct to for searching and li…

9d6b8f0

…sting

GO-5428 Merge branch 'main' into go-5428-api-remove-objectopen-on-sea…

4d20bf5

…rchlist

GO-5428: Remove session token from solve challenge endpoint

e6ab9cc

GO-5428: Fix select and multi_select conversion

303f5a5

GO-5428: Optimize listing templates and object model

628dae1

GO-5428: Remove unused space service

5ef14b6

GO-5428: Refactor GetObjectsInList and list tests

775fac4

GO-5428: Fix object service tests

b1cbd9d

GO-5428: Fix global search tests

d4f761d

GO-5428: Fix search and object tests

3e339ac

GO-5428: Refactor ensureAccountInfo

aef49ac

GO-5428: Refactor GlobalSearch to use GetAllSpaceIds and simplify rec…

2040654

…ord handling

GO-5428: Remove unnecessary filter no_operator from DataviewFilter

d45c28f

GO-5428 Merge branch 'main' into go-5428-api-remove-objectopen-on-sea…

abe0fec

…rchlist

GO-5428: Fix global search tests

f388ac2

GO-4969 Merge branch 'main' into go-4969-rest-api-stage-2

ee70da0

GO-5428: Remove accountService parameter from NewRouter

208340a

GO-4969: Implement GetProperties and GetProperty handlers for propert…

2b2414a

…y retrieval

GO-4969: Make swagger and rename recommended_layout to layout for type

73c7644

GO-4969 Merge branch 'go-5428-api-remove-objectopen-on-searchlist' into

e0c6175

go-4969-rest-api-stage-2

GO-4969: Fix object service interface

af469e7

jmetrikat requested a review from Copilot May 5, 2025 15:54

Copilot AI reviewed May 5, 2025

View reviewed changes

jmetrikat added 6 commits May 5, 2025 22:00

GO-4969: Implement object/file/tag id validation functions

0b7cb4c

GO-4969: Unify object, type and tag layout constants into util

b927fdf

GO-4969: Make fields optional pointers to model PATCH semantics

aad6b6a

GO-4969: Implement UpdateType with detail building

06908cb

GO-4969: Refactor UpdateObject to validate existence and streamline d…

ba99bc5 < 8000 /code>
…etail handling

GO-4969: Fix linter by refactoring imports and property func length

ba6cb08

deff7 changed the base branch from main to release-10-hotfix May 6, 2025 08:00

jmetrikat and others added 14 commits May 6, 2025 11:10

GO-4969: Exclude system properties from getRecommendedPropertiesFromL…

99790c5

…ists

GO-4969: Refactor GetByID util and type properties updating

c553080

GO-5591: Full-text: add missing error handling

b09c2ae

GO-4969: Fix all keys within ObjectSearchSubscribe for collection sea…

1a81d5b

…rch through util

Merge pull request #2389 from anyproto/go-5591-full-text-add-missing-…

1b6d9eb

…error-handling GO-5591: Full-text: add missing error handling

GO-4969: Deprecate separate export, move markdown body to getObject

c9f7371

GO-4969: Fix nested complexity

7a4daee

GO-4969: Fix filtering of _missing_object from property object refere…

d4d7bc3

…nces

GO-4969: Fix list tests

7580817

GO-4969: Add !isHidden filter tagMap search

9ae5cc1

GO-4969: Mock ExportMarkdown in tests for GetObject, CreateObject, an…

62cd6b7

…d GetTemplate

GO-4969 inmemory exporter: do not allow files

718f8e4

GO-4969 fix

1ac71bb

GO-4969: Restrict markdown export to actual objects, don't call for m…

40cf8e2

…edia etc.

requilence approved these changes May 6, 2025

View reviewed changes

jmetrikat added 2 commits May 6, 2025 19:57

GO-4969: Add experimental warning for properties

b1f79b2

GO-4969 in-memory exporter: disable pfd export

d30a977

jmetrikat merged commit ace65b9 into release-10-hotfix May 6, 2025
4 of 6 checks passed

jmetrikat deleted the go-4969-rest-api-stage-2 branch May 6, 2025 18:18

github-actions bot locked and limited conversation to collaborators May 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GO-4969: REST API Stage 2 #2303

GO-4969: REST API Stage 2 #2303
jmetrikat merged 146 commits into release-10-hotfix from go-4969-rest-api-stage-2
May 6, 2025

✅ Passed Tests (2)

🟥 Failures (17)

🔴 Revoking an invite link

🔴 User cancels their join request

🔴 User cancels their join request (Will be retried 🔄)

🔴 User deletes the space and rejoins later

🔴 User deletes the space and rejoins later (Will be retried 🔄)

🔴 Owner changes the rights of a user from Viewer to Editor

🔴 Owner changes the rights of a user from Viewer to Editor (Will be retried 🔄)

🔴 Owner approves a join request with Editor permissions

🔴 Owner approves a join request with Editor permissions (Will be retried 🔄)

🔴 Owner declines a join request

🔴 Owner declines a join request (Will be retried 🔄)

🔴 Owner removes a participant from the space

🔴 Owner removes a participant from the space (Will be retried 🔄)

🔴 Owner deletes a space

🔴 Owner deletes a space (Will be retried 🔄)

🔴 Owner approves leave request

🔴 Owner approves leave request (Will be retried 🔄)

GO-4969: REST API Stage 2 #2303

GO-4969: REST API Stage 2 #2303 jmetrikat merged 146 commits into release-10-hotfix from go-4969-rest-api-stage-2 May 6, 2025

Conversation

New Endpoints

Improvements and Fixes

Breaking Changes

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

✅ Passed Tests (2)

🟥 Failures (17)

🔴 Revoking an invite link

🔴 User cancels their join request

🔴 User cancels their join request (Will be retried 🔄)

🔴 User deletes the space and rejoins later

🔴 User deletes the space and rejoins later (Will be retried 🔄)

🔴 Owner changes the rights of a user from Viewer to Editor

🔴 Owner changes the rights of a user from Viewer to Editor (Will be retried 🔄)

🔴 Owner approves a join request with Editor permissions

🔴 Owner approves a join request with Editor permissions (Will be retried 🔄)

🔴 Owner declines a join request

🔴 Owner declines a join request (Will be retried 🔄)

🔴 Owner removes a participant from the space

🔴 Owner removes a participant from the space (Will be retried 🔄)

🔴 Owner deletes a space

🔴 Owner deletes a space (Will be retried 🔄)

🔴 Owner approves leave request

🔴 Owner approves leave request (Will be retried 🔄)

GO-4969: REST API Stage 2 #2303
jmetrikat merged 146 commits into release-10-hotfix from go-4969-rest-api-stage-2
May 6, 2025