-
Notifications
You must be signed in to change notification settings - Fork 70
GO-5565 Save email during the offline onboarding flow #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
func (e *emailcollector) Name() string { | ||
return "emailcollector" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return CName
|
||
func (e *emailcollector) periodicUpdateEmail(ctx context.Context) error { | ||
// skip running loop if we are on a custom network or in local-only mode | ||
if e.cfg.GetNetworkMode() != pb.RpcAccount_DefaultConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe don't event start periodic function in Run?
core/payments/payments.go
Outdated
return nil, ErrCanNotSign | ||
} | ||
// default OK response | ||
var out pb.RpcMembershipGetVerificationEmailResponse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return &pb.RpcMembershipGetVerificationEmailResponse{}, nil
should be enough
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
|
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?