increase QUIC DEFAULT_MAX_CONNECTIONS_PER_IPADDR_PER_MINUTE to 16 #6665
+2
−2
Conversation
8000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6665 +/- ##
=======================================
Coverage 83.3% 83.3%
=======================================
Files 849 849
Lines 379469 379469
=======================================
+ Hits 316234 316253 +19
+ Misses 63235 63216 -19 🚀 New features to boost your workflow:
|
|
What specific problem are we solving by enforcing this per-ip rate limit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are reported problems having trouble to make connections due the limit is too low when connection is evicted by the server or timed out or other errors.
Summary of Changes
Double the DEFAULT_MAX_CONNECTIONS_PER_IPADDR_PER_MINUTE.
Fixes #