8000 agave-validator: add args tests for run (part 2) by yihau · Pull Request #6667 · anza-xyz/agave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

agave-validator: add args tests for run (part 2) #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

yihau
Copy link
Member
@yihau yihau commented Jun 20, 2025

Problem

#4082

Summary of Changes

--no-genesis-fetch

extract to ./validator/src/commands/run/args/rpc_bootstrap_config.rs

--no-snapshot-fetch

extract to ./validator/src/commands/run/args/rpc_bootstrap_config.rs

--entrypoint

split the method chain and use IndexSet in the middle steps for ensuring the input order

--check-vote-account

extract to ./validator/src/commands/run/args/rpc_bootstrap_config.rs

--known-validator

port validators_set without an exit func

--only-known-rpc

extract to ./validator/src/commands/run/args/rpc_bootstrap_config.rs

--max-genesis-archive-unpacked-size

extract to ./validator/src/commands/run/args/rpc_bootstrap_config.rs

--no-incremental-snapshots

extract to ./validator/src/commands/run/args/rpc_bootstrap_config.rs

misc

  • introduce pretty_assertions

@yihau yihau force-pushed the add-args-run-part-2-new branch from 807b639 to 48ea50a Compare June 20, 2025 13:46
@yihau yihau force-pushed the add-args-run-part-2-new branch from 48ea50a to 0b8c2be Compare June 20, 2025 13:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.08696% with 18 lines in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (8b6d80f) to head (0b8c2be).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6667    +/-   ##
========================================
  Coverage    83.3%    83.3%            
========================================
  Files         849      850     +1     
  Lines      379469   379897   +428     
========================================
+ Hits       316234   316650   +416     
- Misses      63235    63247    +12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yihau yihau marked this pull request as ready for review June 20, 2025 15:14
@yihau yihau requested a review from steviez June 20, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0