v1.17: corrected to not use hardcoded connections count for unstaked (backport of #633) #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry-pick of 592107a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #762 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 806 806
Lines 219348 219348
=======================================
+ Hits 179078 179081 +3
+ Misses 40270 40267 -3 |
ec2f962 to
c342ced
Compare
pgarg66
previously approved these changes
Apr 29, 2024
t-nelson
previously approved these changes
Apr 29, 2024
* corrected to not use hardcoded connections count for unstaked * Fixed a math problem on max_unstaked_load_in_throttling_window * Fixed a unit test failure (cherry picked from commit 592107a) # Conflicts: # streamer/src/nonblocking/quic.rs # streamer/src/nonblocking/stream_throttle.rs
c342ced to
5148853
Compare
t-nelson
approved these changes
Apr 30, 2024
CriesofCarrots
approved these changes
Apr 30, 2024
pgarg66
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max unstaked connections can be passed in value in spawn_server. This will make the QOS incorrectly accounting for the real passed in unstaked max connection count. This is used by jito-relayers.
Do not use the hardcoded one.
This is an automatic backport of pull request #633 done by Mergify.