Modify all branded types such that they will match with any structurally similar type from any package version, going forward #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9270a01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonUnchanged files (127)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
57d3857 to
d9419ea
Compare
d9419ea to
92ca667
Compare
steveluscher
commented
May 6, 2025
steveluscher
commented
May 6, 2025
|
Documentation Preview: https://kit-docs-9inxs4t3b-anza-tech.vercel.app |
lorisleiva
approved these changes
May 7, 2025
There was a problem hiding this comment.
Beautiful! There are other unique symbols we should consider cleaning such as transaction type flags (e.g. FullySignedTransaction). Refer to my previous comment for this.
92ca667 to
2f4b511
Compare
9376ffa to
509f7f6
Compare
steveluscher
commented
May 7, 2025
2f4b511 to
dfb0faf
Compare
509f7f6 to
45bed58
Compare
dfb0faf to
1dc5153
Compare
45bed58 to
79fde4c
Compare
1dc5153 to
7ec918b
Compare
79fde4c to
3a7178b
Compare
7ec918b to
12e89b4
Compare
3a7178b to
064e825
Compare
12e89b4 to
445cc6c
Compare
064e825 to
f0cceaf
Compare
Merge activity
|
…lly similar type from any package version, going forward
445cc6c to
9270a01
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Two versions of any given package may introduce two distinct instances of our branded types into a project. That is to say you might get the
Addresstype from v2.0.0 and v2.1.0 in the same project.Summary of Changes
Here we use the type utilities in the previous stacked PR to reimagine these types as structurally identical, rather than having an identity that's tied to one particular instance of a module.
This will make it so that
Addressand other branded types like it are compatible from version v2.1.1 and onward.Fixes #459