8000 Remove I prefixes before Transaction types by lorisleiva · Pull Request #426 · anza-xyz/kit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove I prefixes before Transaction types #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 1 commit into from
May 14, 2025
Merged

Remove I prefixes before Transaction types #426

merged 1 commit into from
May 14, 2025

Conversation

lorisleiva
Copy link
Member
@lorisleiva lorisleiva commented May 1, 2025 •
edited
Loading

Most of the types in the transactions and transaction-messages are not prefixed by the letter I apart from four of them. This PR makes them more consistent with the rest of the library by removing that prefix.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d42093a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@solana/transaction-messages Minor
@solana/transactions Minor
@solana/signers Minor
@solana/errors Minor
@solana/kit Minor
@solana/programs Minor
@solana/rpc-api Minor
@solana/rpc-subscriptions-api Minor
@solana/transaction-confirmation Minor
@solana/compat Minor
@solana/react Minor
@solana/rpc-graphql Minor
@solana/accounts Minor
@solana/a 8000 ddresses Minor
@solana/assertions Minor
@solana/codecs-core Minor
@solana/codecs-data-structures Minor
@solana/codecs-numbers Minor
@solana/codecs-strings Minor
@solana/instructions Minor
@solana/keys Minor
@solana/options Minor
@solana/rpc-spec Minor
@solana/rpc-subscriptions-channel-websocket Minor
@solana/rpc-subscriptions-spec Minor
@solana/rpc-subscriptions Minor
@solana/rpc-transformers Minor
@solana/rpc-transport-http Minor
@solana/rpc-types Minor
@solana/rpc Minor
@solana/subscribable Minor
@solana/sysvars Minor
@solana/rpc-parsed-types Minor
@solana/codecs Minor
@solana/fast-stable-stringify Minor
@solana/functional Minor
@solana/nominal-types Minor
@solana/promises Minor
@solana/rpc-spec-types Minor
@solana/webcrypto-ed25519-polyfill Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link
vercel bot commented May 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kit-docs ❌ Failed (Inspect) May 2, 2025 4:58pm

@lorisleiva lorisleiva mentioned this pull request May 1, 2025
Merged
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented May 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced May 1, 2025
Merged
Merged
Merged
Merged
@bundlemon BundleMon
Copy link
bundlemon bot commented May 1, 2025 •
edited
Loading

BundleMon

Unchanged files (127)
Status Path Size Limits
✅ @solana/kit production bundle
kit/dist/index.production.min.js
 34.38KB -
✅ rpc-graphql/dist/index.browser.mjs
 18.78KB -
✅ rpc-graphql/dist/index.native.mjs
 18.78KB -
✅ rpc-graphql/dist/index.node.mjs
 18.78KB -
✅ errors/dist/index.node.mjs
 14.54KB -
✅ errors/dist/index.browser.mjs
 14.52KB -
✅ errors/dist/index.native.mjs
 14.52KB -
✅ transaction-messages/dist/index.browser.mjs
 7.24KB -
✅ transaction-messages/dist/index.native.mjs
 7.24KB -
✅ transaction-messages/dist/index.node.mjs
 7.24KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.77KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.57KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.56KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.54KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.38KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ codecs-core/dist/index.browser.mjs
 3.3KB -
✅ codecs-core/dist/index.native.mjs
 3.3KB -
✅ codecs-core/dist/index.node.mjs
 3.3KB -
✅ rpc-transformers/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.native.mjs
 2.93KB -
✅ rpc-transformers/dist/index.node.mjs
 2.93KB -
✅ addresses/dist/index.browser.mjs
 2.86KB -
✅ addresses/dist/index.nati 8000 ve.mjs
 2.86KB -
✅ addresses/dist/index.node.mjs
 2.86KB -
✅ kit/dist/index.browser.mjs
 2.71KB -
✅ kit/dist/index.native.mjs
 2.71KB -
✅ kit/dist/index.node.mjs
 2.71KB -
✅ signers/dist/index.browser.mjs
 2.63KB -
✅ signers/dist/index.native.mjs
 2.63KB -
✅ signers/dist/index.node.mjs
 2.63KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.48KB -
✅ codecs-strings/dist/index.native.mjs
 2.45KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.4KB -
✅ sysvars/dist/index.browser.mjs
 2.35KB -
✅ sysvars/dist/index.native.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.34KB -
✅ sysvars/dist/index.node.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.34KB -
✅ transactions/dist/index.browser.mjs
 2.22KB -
✅ transactions/dist/index.native.mjs
 2.22KB -
✅ transactions/dist/index.node.mjs
 2.22KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.13KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.08KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.08KB -
✅ keys/dist/index.browser.mjs
 2.02KB -
✅ keys/dist/index.native.mjs
 2.02KB -
✅ keys/dist/index.node.mjs
 2.02KB -
✅ codecs-numbers/dist/index.native.mjs
 2.01KB -
✅ codecs-numbers/dist/index.browser.mjs
 2.01KB -
✅ codecs-numbers/dist/index.node.mjs
 2.01KB -
✅ react/dist/index.native.mjs
 1.99KB -
✅ react/dist/index.browser.mjs
 1.99KB -
✅ react/dist/index.node.mjs
 1.99KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.91KB -
✅ rpc/dist/index.native.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.73KB -
✅ rpc-types/dist/index.browser.mjs
 1.6KB -
✅ rpc-types/dist/index.native.mjs
 1.6KB -
✅ rpc-types/dist/index.node.mjs
 1.6KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.13KB -
✅ accounts/dist/index.native.mjs
 1.12KB -
✅ accounts/dist/index.node.mjs
 1.12KB -
✅ compat/dist/index.browser.mjs
 971B -
✅ compat/dist/index.native.mjs
 970B -
✅ compat/dist/index.node.mjs
 968B -
✅ rpc-spec-types/dist/index.browser.mjs
 964B -
✅ rpc-api/dist/index.browser.mjs
 963B -
✅ rpc-api/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 962B -
✅ rpc-api/dist/index.node.mjs
 961B -
✅ rpc-spec-types/dist/index.node.mjs
 961B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 829B -
✅ rpc-spec/dist/index.native.mjs
 829B -
✅ rpc-spec/dist/index.node.mjs
 828B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 783B -
✅ instructions/dist/index.browser.mjs
 769B -
✅ instructions/dist/index.native.mjs
 768B -
✅ instructions/dist/index.node.mjs
 767B -
✅ fast-stable-stringify/dist/index.browser.mjs
 726B -
✅ fast-stable-stringify/dist/index.native.mjs
 725B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.node.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ programs/dist/index.browser.mjs
 329B -
✅ programs/dist/index.native.mjs
 327B -
✅ programs/dist/index.node.mjs
 325B -
✅ event-target-impl/dist/index.node.mjs
 233B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ crypto-impl/dist/index.node.mjs
 114B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

Total files change -2B 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@lorisleiva lorisleiva marked this pull request as ready for review May 1, 2025 17:49
mcintyre94
mcintyre94 approved these changes May 2, 2025
View reviewed changes
Copy link
Member
@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, and prefer not having the I anywhere

@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 0825090 to f33ef5d Compare May 2, 2025 16:11
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from 9271fc2 to c3c76e1 Compare May 2, 2025 16:11
@lorisleiva lorisleiva mentioned this pull request May 2, 2025
Merged
steveluscher
steveluscher approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator
@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didntreadbadger

@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from c3c76e1 to 7f24670 Compare May 5, 2025 13:45
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from f33ef5d to 18f576a Compare May 5, 2025 13:45
@lorisleiva
Copy link
Member Author

Should I do this with the IInstruction types as well in subsequent PRs? 👀

Since this whole thing is gonna bump to v3 anyway.

@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from 7f24670 to 03ae199 Compare May 5, 2025 14:39
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 18f576a to 243b7f6 Compare May 5, 2025 14:39
@steveluscher Graphite App
Copy link
Collaborator

Renaming these types will force users and library authors to rename theirs too, and to force people who depend on them to use >3.0. If there's any time to do this, it's now before there's more code that depends on this, but we could also save people the trouble now.

@lorisleiva
Copy link
Member Author

For sure. I was kind of hoping we'd wait until more of my refactoring PRs (there's a lot more to come after this in my quest to make room for instruction plans).

Maybe it's time for a v3 feature branch?

@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from 03ae199 to ca4a84a Compare May 6, 2025 08:26
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 243b7f6 to 89bf30d Compare May 6, 2025 08:26
@lorisleiva lorisleiva mentioned this pull request May 6, 2025
Open
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 89bf30d to 5aeb05a Compare May 6, 2025 09:02
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from 897035d to 37a3d5c Compare May 8, 2025 15:15
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from dbbc080 to 87bbf91 Compare May 8, 2025 15:15
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from 37a3d5c to dc7aa5e Compare May 8, 2025 15:43
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 87bbf91 to 4e54279 Compare May 8, 2025 15:43
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from dc7aa5e to eea0da4 Compare May 8, 2025 15:53
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 4e54279 to a864afe Compare May 8, 2025 15:53
@lorisleiva lorisleiva mentioned this pull request May 8, 2025
Open
steveluscher
steveluscher reviewed May 8, 2025
View reviewed changes
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from eea0da4 to fb46a16 Compare May 8, 2025 21:40
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch 3 times, most recently from f3093e0 to 24b5bdc Compare May 8, 2025 21:48
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from fb46a16 to 2d27e4b Compare May 8, 2025 21:48
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 24b5bdc to f3093e0 Compare May 12, 2025 10:04
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch 2 times, most recently from b7703f6 to d64f022 Compare May 12, 2025 10:17
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from f3093e0 to 56aa6ee Compare May 12, 2025 10:17
@lorisleiva lorisleiva mentioned this pull request May 12, 2025
Merged
@lorisleiva lorisleiva force-pushed the 05-01-add_transaction_size_helpers branch from 56aa6ee to 867e852 Compare May 14, 2025 08:31
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from d64f022 to 4eb6899 Compare May 14, 2025 08:31
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented May 14, 2025 •
edited
Loading

Merge activity

  • May 14, 5:56 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 14, 5:59 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 14, 6:01 AM EDT: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from 05-01-add_transaction_size_helpers to graphite-base/426 May 14, 2025 09:57
@lorisleiva lorisleiva changed the base branch from graphite-base/426 to main May 14, 2025 09:57
@lorisleiva lorisleiva force-pushed the 05-01-remove_i_prefixes_before_transaction_types branch from 4eb6899 to d42093a Compare May 14, 2025 09:58
@lorisleiva lorisleiva merged commit b7dfe03 into main May 14, 2025
14 checks passed
@lorisleiva lorisleiva deleted the 05-01-remove_i_prefixes_before_transaction_types branch May 14, 2025 10:01
@github-actions github-actions bot mentioned this pull request May 14, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@mcintyre94 mcintyre94 mcintyre94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorisleiva @steveluscher @mcintyre94
0