10000 Add `innerInstruction` typetest for `simulateTransaction` by steveluscher · Pull Request #568 · anza-xyz/kit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add innerInstruction typetest for simulateTransaction #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Add innerInstruction typetest for simulateTransaction #568

merged 1 commit into from
Jun 26, 2025

Conversation

steveluscher
Copy link
Collaborator

Problem

This was missing a test to assert that innerInstruction only materializes on the response when asked for.

Summary of Changes

Added a typetest.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 609f74f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Jun 24, 2025
Open
Merged
@steveluscher Graphite App
Copy link
Collaborator Author
steveluscher commented Jun 24, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@steveluscher steveluscher mentioned this pull request Jun 24, 2025
Merged
@steveluscher steveluscher force-pushed the 06-24-add_replacementblockhash_to_rpcsimulatetransactionresult_ branch from 74566bf to ddef1fb Compare June 24, 2025 18:38
@steveluscher steveluscher force-pushed the 06-24-add_innerinstruction_typetest_for_simulatetransaction_ branch from 81a8e7a to 92b68dc Compare June 24, 2025 18:38
@bundlemon BundleMon
Copy link
bundlemon bot commented Jun 24, 2025 •
edited
Loading

BundleMon

Unchanged files (127)
Status Path Size Limits
✅ @solana/kit production bundle
kit/dist/index.production.min.js
 34.39KB -
✅ rpc-graphql/dist/index.browser.mjs
 18.82KB -
✅ rpc-graphql/dist/index.native.mjs
 18.82KB -
✅ rpc-graphql/dist/index.node.mjs
 18.82KB -
✅ errors/dist/index.node.mjs
 14.54KB -
✅ errors/dist/index.browser.mjs
 14.52KB -
✅ errors/dist/index.native.mjs
 14.52KB -
✅ transaction-messages/dist/index.browser.mjs
 7.24KB -
✅ transaction-messages/dist/index.native.mjs
 7.24KB -
✅ transaction-messages/dist/index.node.mjs
 7.24KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.77KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.57KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.56KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.54KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.38KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ codecs-core/dist/index.browser.mjs
 3.3KB -
✅ codecs-core/dist/index.native.mjs
 3.3KB -
✅ codecs-core/dist/index.node.mjs
 3.3KB -
✅ rpc-transformers/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.native.mjs
 2.93KB -
✅ rpc-transformers/dist/index.node.mjs
 2.93KB -
✅ addresses/dist/index.browser.mjs
 2.86KB -
✅ addresses/dist/index.native.mjs
 2.86KB -
✅ addresses/dist/index.node.mjs
 2.86KB -
✅ kit/dist/index.browser.mjs
 2.71KB -
✅ kit/dist/index.native.mjs
 2.71KB -
✅ kit/dist/index.node.mjs
 2.71KB -
✅ signers/dist/index.browser.mjs
 2.63KB -
✅ signers/dist/index.native.mjs
 2.63KB -
✅ signers/dist/index.node.mjs
 2.62KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.48KB -
✅ codecs-strings/dist/index.native.mjs
 2.45KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.39KB -
✅ sysvars/dist/index.browser.mjs
 2.35KB -
✅ sysvars/dist/index.native.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.34KB -
✅ sysvars/dist/index.node.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.34KB -
✅ transactions/dist/index.browser.mjs
 2.27KB -
✅ transactions/dist/index.native.mjs
 2.27KB -
✅ transactions/dist/index.node.mjs
 2.26KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.14KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.09KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.09KB -
✅ keys/dist/index.browser.mjs
 2.02KB -
✅ keys/dist/index.native.mjs
 2.02KB -
✅ keys/dist/index.node.mjs
 2.02KB -
✅ codecs-numbers/dist/index.native.mjs
 2.01KB -
✅ codecs-numbers/dist/index.browser.mjs
 2.01KB -
✅ codecs-numbers/dist/index.node.mjs
 2.01KB -
✅ react/dist/index.native.mjs
 1.99KB -
✅ react/dist/index.browser.mjs
 1.99KB -
✅ react/dist/index.node.mjs
 1.99KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.91KB -
✅ rpc/dist/index.native.mjs
 1.8KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.73KB -
✅ rpc-types/dist/index.browser.mjs
 1.53KB -
✅ rpc-types/dist/index.native.mjs
 1.53KB -
✅ rpc-types/dist/index.node.mjs
 1.53KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.13KB -
✅ accounts/dist/index.native.mjs
 1.12KB -
✅ accounts/dist/index.node.mjs
 1.12KB -
✅ compat/dist/index.browser.mjs
 971B -
✅ compat/dist/index.native.mjs
 970B -
✅ compat/dist/index.node.mjs
 968B -
✅ rpc-spec-types/dist/index.browser.mjs
 964B -
✅ rpc-api/dist/index.browser.mjs
 963B -
✅ rpc-api/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 962B -
✅ rpc-api/dist/index.node.mjs
 961B -
✅ rpc-spec-types/dist/index.node.mjs
 961B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 852B -
✅ rpc-spec/dist/index.native.mjs
 851B -
✅ rpc-spec/dist/index.node.mjs
 850B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 783B -
✅ instructions/dist/index.browser.mjs
 769B -
✅ instructions/dist/index.native.mjs
 768B -
✅ instructions/dist/index.node.mjs
 767B -
✅ fast-stable-stringify/dist/index.browser.mjs
 726B -
✅ fast-stable-stringify/dist/index.native.mjs
 725B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.node.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ programs/dist/index.browser.mjs
 329B -
✅ programs/dist/index.native.mjs
 327B -
✅ programs/dist/index.node.mjs
 325B -
✅ event-target-impl/dist/index.node.mjs
 230B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.node.mjs
 111B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@steveluscher steveluscher force-pushed the 06-24-add_innerinstruction_typetest_for_simulatetransaction_ branch from 92b68dc to 75729f3 Compare June 24, 2025 18:47
@steveluscher steveluscher force-pushed the 06-24-add_replacementblockhash_to_rpcsimulatetransactionresult_ branch from ddef1fb to ad44abe Compare June 24, 2025 18:47
@steveluscher steveluscher force-pushed the 06-24-add_innerinstruction_typetest_for_simulatetransaction_ branch from 75729f3 to 39d8a3e Compare June 24, 2025 18:50
@steveluscher steveluscher force-pushed the 06-24-add_replacementblockhash_to_rpcsimulatetransactionresult_ branch 2 times, most recently from 13a95f1 to 6b52e21 Compare June 24, 2025 18:51
@steveluscher steveluscher force-pushed the 06-24-add_innerinstruction_typetest_for_simulatetransaction_ branch from 39d8a3e to aabe662 Compare June 24, 2025 18:51
@steveluscher steveluscher force-pushed the 06-24-add_replacementblockhash_to_rpcsimulatetransactionresult_ branch from 6b52e21 to b5cc010 Compare June 24, 2025 18:54
@steveluscher steveluscher force-pushed the 06-24-add_innerinstruction_typetest_for_simulatetransaction_ branch from aabe662 to 51c4c5d Compare June 24, 2025 18:54
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 24, 2025 •
edited
Loading

Documentation Preview: https://kit-docs-hxdvtvebm-anza-tech.vercel.app

@steveluscher Graphite App
Copy link
Collaborator Author
steveluscher commented Jun 25, 2025 •
edited
Loading

Merge activity

@steveluscher steveluscher changed the base branch from 06-24-add_replacementblockhash_to_rpcsimulatetransactionresult_ to graphite-base/568 June 26, 2025 05:42
@steveluscher steveluscher changed the base branch from graphite-base/568 to main June 26, 2025 05:45
@steveluscher steveluscher force-pushed the 06-24-add_innerinstruction_typetest_for_simulatetransaction_ branch from 51c4c5d to 609f74f Compare June 26, 2025 05:46
@steveluscher steveluscher merged commit 66ff9c5 into main Jun 26, 2025
13 checks passed
@steveluscher steveluscher deleted the 06-24-add_innerinstruction_typetest_for_simulatetransaction_ branch June 26, 2025 05:49
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lorisleiva lorisleiva lorisleiva approved these changes

@buffalojoec buffalojoec buffalojoec approved these changes

@mcintyre94 mcintyre94 Awaiting requested review from mcintyre94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveluscher @lorisleiva @buffalojoec
0