8000 TEZ-4330. Import external tez component em-tgraph by jteagles · Pull Request #147 · apache/tez · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TEZ-4330. Import external tez component em-tgraph #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TEZ-4330. Import external tez component em-tgraph #147

wants to merge 1 commit into from

Conversation

jteagles
Copy link
Contributor

Co-authored-by: Sreenath Somarajapuram sree@apache.org

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 jshint 0m 6s There were no new jshint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
14m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/1/artifact/out/Dockerfile
GITHUB PR #147
Optional Tests dupname asflicense jshint
uname Linux a3c2f5e528b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / e2c4ee0
Max. process+thread count 51 (vs. ulimit of 5500)
modules C: tez-ui U: tez-ui
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/1/console
versions git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

abstractdog
abstractdog requested changes Aug 26, 2021
View reviewed changes
tez-ui/src/main/webapp/app/controllers/dag/swimlane.js Outdated
@@ -19,10 +19,10 @@
import Ember from 'ember';

import MultiTableController from '../multi-table';
import ColumnDefinition from 'em-table/utils/column-definition';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be part of em-table import, which is TEZ-4329?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This change was in em-table PR as well. I'm glad you caught this accidental import. I'll merge em-table and then audit the list of imports to make sure we are good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreenaths / @abstractdog updated to fix import. should be ready for review again

@abstractdog abstractdog mentioned this pull request Aug 26, 2021
Merged
@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 jshint 0m 6s There were no new jshint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
2m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/2/artifact/out/Dockerfile
GITHUB PR #147
Optional Tests dupname asflicense jshint
uname Linux 665a9c424f87 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 0ccf440
Max. process+thread count 51 (vs. ulimit of 5500)
modules C: tez-ui U: tez-ui
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/2/console
versions git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 12m 42s master passed
+1 💚 javadoc 0m 44s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 22s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Patch Compile Tests _
+1 💚 mvninstall 1m 21s the patch passed
+1 💚 jshint 52m 35s There were no new jshint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 21s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 20s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Other Tests _
+1 💚 unit 1m 52s tez-ui in the patch passed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
72m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/artifact/out/Dockerfile
GITHUB PR #147
Optional Tests dupname asflicense javac javadoc unit jshint
uname Linux 974ec6de6131 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 0ccf440
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/testReport/
Max. process+thread count 93 (vs. ulimit of 5500)
modules C: tez-ui U: tez-ui
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/console
versions git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@sreenaths
TEZ-4330. Import external tez component em-tgraph
fd3b06c 
Co-authored-by: Sreenath Somarajapuram <sree@apache.org>
@tez-yetus
Copy link
8000 tez-yetus commented Aug 26, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 12m 54s master passed
+1 💚 javadoc 0m 45s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 20s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Patch Compile Tests _
+1 💚 mvninstall 1m 31s the patch passed
+1 💚 jshint 56m 18s There were no new jshint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 18s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 20s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Other Tests _
+1 💚 unit 2m 2s tez-ui in the patch passed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
76m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/artifact/out/Dockerfile
GITHUB PR #147
Optional Tests dupname asflicense javac javadoc unit jshint
uname Linux 2381fcf8a5f9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 0ccf440
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/testReport/
Max. process+thread count 92 (vs. ulimit of 5500)
modules C: tez-ui U: tez-ui
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/console
versions git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus tez-yetus mentioned this pull request Sep 3, 2021
Closed
@tez-yetus tez-yetus mentioned this pull request Oct 1, 2021
Merged
@tez-yetus tez-yetus mentioned this pull request Oct 14, 2021
Merged
@abstractdog
Copy link
Contributor

my previous comment was addressed, other than that this is mostly a copy from another repo (I mean don't have to read it line-by-line), precommit is green, so it's a +1 from my side
please let us know @sreenaths if you found any problems, otherwise I'll merge this and maybe go for mock-ats

@abstractdog abstractdog self-requested a review October 19, 2021 09:17
@tez-yetus tez-yetus mentioned this pull request Nov 14, 2021
Merged
@tez-yetus tez-yetus mentioned this pull request Dec 3, 2021
Merged
This was referenced Apr 14, 2025
Closed
Closed
Merged
Open
This was referenced Apr 27, 2025
Merged
Merged
Merged
@tez-yetus tez-yetus mentioned this pull request May 7, 2025
Open
@tez-yetus tez-yetus mentioned this pull request May 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreenaths sreenaths sreenaths left review comments

@abstractdog abstractdog abstractdog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jteagles @tez-yetus @abstractdog @sreenaths
0