TEZ-4603: Bucket Map Join can hang if the source vertex parallelism i… by mayankkunwar · Pull Request #392 · apache/tez · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s changed by reducer autoparallelism Description
The changes in this PR are w.r.t. when auto reduce parallelism kicks in, we try to updates downstream vertex's expected number of input, so that the execution hang could be avoided.
In this case, the type of edge between reducer and downstream vertices (Mapper) is a CUSTOM edge. [Reducer --(C)--> Mapper]
The CUSTOM edge is because of Bucket Map Join
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
2m 5s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 52s
master passed
+1 💚
compile
1m 6s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
1m 4s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 13s
master passed
+1 💚
javadoc
1m 6s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
1m 3s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 45s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 15s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 7s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 45s
the patch passed
+1 💚
compile
0m 43s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 43s
the patch passed
+1 💚
compile
0m 40s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 40s
the patch passed
-0 ⚠️
checkstyle
0m 9s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 33s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 35s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
-1 ❌
findbugs
0m 45s
tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚
unit
1m 51s
tez-api in the patch passed.
+1 💚
unit
4m 19s
tez-runtime-library in the patch passed.
+1 💚
unit
4m 10s
tez-dag in the patch passed.
+1 💚
asflicense
0m 23s
The patch does not generate ASF License warnings.
47m 29s
Reason
Tests
FindBugs
module:tez-dag
Load of known null value in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:[line 2004]
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
1m 56s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 43s
master passed
+1 💚
compile
1m 3s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
1m 3s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 14s
master passed
+1 💚
javadoc
1m 0s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
1m 3s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 42s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 12s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 7s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 45s
the patch passed
+1 💚
compile
0m 42s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 42s
the patch passed
+1 💚
compile
0m 39s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 39s
the patch passed
-0 ⚠️
checkstyle
0m 9s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 32s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 37s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
-1 ❌
findbugs
0m 44s
tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚
unit
1m 53s
tez-api in the patch passed.
+1 💚
unit
4m 16s
tez-runtime-library in the patch passed.
+1 💚
unit
4m 6s
tez-dag in the patch passed.
+1 💚
asflicense
0m 23s
The patch does not generate ASF License warnings.
34m 55s
Reason
Tests
FindBugs
module:tez-dag
Load of known null value in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:[line 2004]
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
1m 54s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 51s
master passed
+1 💚
compile
1m 5s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
1m 0s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 2s
master passed
+1 💚
javadoc
0m 54s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 46s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 41s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 6s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 6s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 44s
the patch passed
+1 💚
compile
0m 50s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 50s
the patch passed
+1 💚
compile
0m 41s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 41s
the patch passed
-0 ⚠️
checkstyle
0m 8s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 31s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 32s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
-1 ❌
findbugs
0m 46s
tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚
unit
1m 50s
tez-api in the patch passed.
+1 💚
unit
4m 19s
tez-runtime-library in the patch passed.
+1 💚
unit
4m 5s
tez-dag in the patch passed.
+1 💚
asflicense
0m 24s
The patch does not generate ASF License warnings.
34m 17s
Reason
Tests
FindBugs
module:tez-dag
Load of known null value in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:[line 2004]
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
1m 53s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 52s
master passed
+1 💚
compile
0m 58s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
0m 53s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 2s
master passed
+1 💚
javadoc
0m 56s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 48s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 19s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 6s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 43s
the patch passed
+1 💚
compile
0m 49s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 49s
the patch passed
+1 💚
compile
0m 44s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 44s
the patch passed
-0 ⚠️
checkstyle
0m 8s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 34s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 33s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
-1 ❌
findbugs
0m 48s
tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚
unit
1m 48s
tez-api in the patch passed.
+1 💚
unit
4m 22s
tez-runtime-library in the patch passed.
+1 💚
unit
4m 7s
tez-dag in the patch passed.
+1 💚
asflicense
0m 23s
The patch does not generate ASF License warnings.
34m 38s
Reason
Tests
FindBugs
module:tez-dag
Load of known null value in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:in org.apache.tez.dag.app.dag.impl.VertexImpl.setParallelismWrapper(int, VertexLocationHint, Map, Map, boolean) At VertexImpl.java:[line 2004]
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
1m 52s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 46s
master passed
+1 💚
compile
1m 3s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
1m 2s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 1s
master passed
+1 💚
javadoc
0m 56s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 52s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 44s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 16s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 8s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 49s
the patch passed
+1 💚
compile
0m 49s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 49s
the patch passed
+1 💚
compile
0m 42s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 42s
the patch passed
-0 ⚠️
checkstyle
0m 10s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 31s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 35s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
1m 54s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 40s
master passed
+1 💚
compile
1m 6s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
1m 5s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 10s
master passed
+1 💚
javadoc
1m 10s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
1m 2s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 47s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 16s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 7s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 45s
the patch passed
+1 💚
compile
0m 43s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 43s
the patch passed
+1 💚
compile
0m 43s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 43s
the patch passed
-0 ⚠️
checkstyle
0m 8s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 32s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 36s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
1m 53s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 42s
master passed
+1 💚
compile
1m 2s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
1m 0s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 10s
master passed
+1 💚
javadoc
1m 6s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
1m 1s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 18s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 7s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 45s
the patch passed
+1 💚
compile
0m 43s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 43s
the patch passed
+1 💚
compile
0m 40s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 40s
the patch passed
-0 ⚠️
checkstyle
0m 9s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 31s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 34s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗
mvndep
2m 0s
Maven dependency ordering for branch
+1 💚
mvninstall
7m 44s
master passed
+1 💚
compile
1m 5s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
compile
1m 5s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
checkstyle
1m 11s
master passed
+1 💚
javadoc
1m 3s
master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
1m 0s
master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+0 🆗
spotbugs
0m 45s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
2m 13s
master passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 8s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 42s
the patch passed
+1 💚
compile
0m 43s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javac
0m 43s
the patch passed
+1 💚
compile
0m 42s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚
javac
0m 42s
the patch passed
-0 ⚠️
checkstyle
0m 9s
tez-runtime-library: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
0m 31s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚
javadoc
0m 36s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s changed by reducer autoparallelism
Description
The changes in this PR are w.r.t. when auto reduce parallelism kicks in, we try to updates downstream vertex's expected number of input, so that the execution hang could be avoided.
In this case, the type of edge between reducer and downstream vertices (Mapper) is a CUSTOM edge.
[Reducer --(C)--> Mapper]
The CUSTOM edge is because of Bucket Map Join
TODO: Unit Tests