8000 [CONV3D] remove incorrect schedule for conv3d_ndhwc by optima2005 · Pull Request #4659 · apache/tvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CONV3D] remove incorrect schedule for conv3d_ndhwc #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[CONV3D] remove incorrect schedule for conv3d_ndhwc #4659

wants to merge 2 commits into from

Conversation

optima2005
Copy link
Contributor

This is a fix to #4604, to remove unnecessary and incorrect cuda schedule for conv3d_ndhwc

@masahi @icemelon9

@tqchen tqchen added status: need test case need test cases to cover the change status: need review labels Jan 8, 2020
@masahi
Copy link
Member
masahi commented Jan 9, 2020

if you remove schedule_conv3d_ndhwc_cuda, what happens if schedule_conv3d_ndhwc was called on cuda target? You get an error?

@icemelon
Copy link
Member
icemelon commented Jan 9, 2020

Never mind. I'll fix the conv3d issue in #4644 since I'm changing the TOPI.

@icemelon icemelon closed this Jan 9, 2020
@optima2005
Copy link
Contributor Author

@masahi Yes. it would report error. Currently at least in TF frontend, the NHWC for conv2d, NDHWC for conv3d are forced to transform to NCHW/NCDHW layout. Please see this, this and this. I guess that might be under perormance consideration. But a more user friendly approach may be needed to notice the user TVM not supporting those layouts under cuda target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: need review status: need test case need test cases to cover the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@optima2005 @masahi @icemelon @tqchen
0