Add is_floating_point and div_ PyTorch ops
#7128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, please run |
|
Hi, I just ran |
|
Have you looked at |
masahi
approved these changes
Dec 18, 2020
|
Thanks @TylerADavis |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
* Add div_ and is_floating_point operators * Add handling of exprs to op, update tests * Revert changes to tests * reintroduce newline * Fix style
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
* Add div_ and is_floating_point operators * Add handling of exprs to op, update tests * Revert changes to tests * reintroduce newline * Fix style
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* Add div_ and is_floating_point operators * Add handling of exprs to op, update tests * Revert changes to tests * reintroduce newline * Fix style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
This PR adds support for the
is_floating_pointanddiv_PyTorch operations, and closes #6239 .This PR does not include a unit test for
div_as there is currently no unit test fordiv, and they share an implementation. Additionally, while I wrote a unit test foris_floating_point()(see https://github.com/apache/tvm/compare/main...TylerADavis:tyler_add_ops_incl_tests?expand=1), it is not included in this PR as models consisting solely ofis_floating_pointare compiled to constant graphs with no inputs, and the current testing infrastructure assumes that all graphs have inputs. The unit test foris_floating_point()tests the operator withtorch.jit.scriptandtorch.jit.tracewith inputs consisting ofint8, float64, float32, andfloat16. Each of these test cases passes.