[ROCM] Fix undefined symbols by adding library #8446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
approved these changes
Jul 12, 2021
|
Thanks @mvermeulen I've also hit this problem. cc @Lunderberg |
|
@mvermeulen Thank you for the fix! I had initially thought that the CI would catch a failing compile, but it looks like the CI's OSX compilation only has LLVM/Metal runtimes enabled, and not ROCm. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Add libhsa-runtime64 reference. * Remove lib in library definition.
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* Add libhsa-runtime64 reference. * Remove lib in library definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8178 added a check for undefined symbols when the target was linked.
This broke the ROCm build because some symbols were resolved by libhsaruntime64.so which is present at execution time, but not present at link time. This PR fixes the unresolved symbol issue by linking with libhsaruntime64.so if present.