8000 Fix issue 1955 - List comprehension in WHERE clause by MuhammadTahaNaveed · Pull Request #2094 · apache/age · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix issue 1955 - List comprehension in WHERE clause #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix issue 1955 - List comprehension in WHERE clause #2094

merged 1 commit into from
Sep 9, 2024

Conversation

MuhammadTahaNaveed
Copy link
Member
@MuhammadTahaNaveed MuhammadTahaNaveed commented Sep 9, 2024 •
edited
Loading
  • Fixed issue when MATCH clause variable is referenced inside list comprehension in WHERE clause or in property constraint.
  • Added regression tests.

resolves #1955

< 8000 div data-view-component="true" class="TimelineItem TimelineItem--condensed">
@MuhammadTahaNaveed
Fix issue 1955 - List comprehension in WHERE clause
58d9519 
- Fixed issue when MATCH clause variable is referenced inside list
  comprehension in WHERE clause or in property constraint.
- Added regression tests.
@github-actions github-actions bot added master override-stale To keep issues/PRs untouched from stale action labels Sep 9, 2024
@jrgemignani jrgemignani merged commit 0f0d9be into apache:master Sep 9, 2024
7 checks passed
@MuhammadTahaNaveed MuhammadTahaNaveed deleted the issue-1955 branch September 9, 2024 17:32
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Apr 25, 2025
@MuhammadTahaNaveed
Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094
8d4915f 
)"

This reverts commit 0f0d9be.
jrgemignani pushed a commit that referenced this pull request Jun 10, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (#2169)
1251096 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
90cab71 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Fix issue 1955 - List comprehension in WHERE clause (apache#2094)
5f646f1 
- Fixed issue when MATCH clause variable is referenced inside list
  comprehension in WHERE clause or in property constraint.
- Added regression tests.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
099dd97 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Fix issue 1955 - List comprehension in WHERE clause (apache#2094)
6528182 
- Fixed issue when MATCH clause variable is referenced inside list
  comprehension in WHERE clause or in property constraint.
- Added regression tests.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
2583c7a 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Fix issue 1955 - List comprehension in WHERE clause (apache#2094)
060497e 
- Fixed issue when MATCH clause variable is referenced inside list
  comprehension in WHERE clause or in property constraint.
- Added regression tests.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
0b32310 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
10000
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
2dc3140 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
8bd6a5d 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
d1bd110 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
940f65b 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
MuhammadTahaNaveed added a commit to MuhammadTahaNaveed/age that referenced this pull request Jun 11, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (apache#2169)
9772a70 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (apache#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (apache#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (apache#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (apache#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
jrgemignani pushed a commit that referenced this pull request Jun 17, 2025
@MuhammadTahaNaveed @jrgemignani
Fix issue 1955 - List comprehension in WHERE clause (#2094)
cb65862 
- Fixed issue when MATCH clause variable is referenced inside list
  comprehension in WHERE clause or in property constraint.
- Added regression tests.
jrgemignani pushed a commit that referenced this pull request Jun 17, 2025
@MuhammadTahaNaveed @jrgemignani
Reimplement list comprehension (#2169)
489e49f 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
jrgemignani pushed a commit that referenced this pull request Jun 17, 2025
@MuhammadTahaNaveed @jrgemignani
Fix issue 1955 - List comprehension in WHERE clause (#2094)
7b2acfd 
- Fixed issue when MATCH clause variable is referenced inside list
  comprehension in WHERE clause or in property constraint.
- Added regression tests.
jrgemignani pushed a commit that referenced this pull request Jun 17, 2025
@MuhammadTahaNaveed @jrgemignani
Reimplement list comprehension (#2169)
c2faa13 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
jrgemignani pushed a commit that referenced this pull request Jun 17, 2025
@MuhammadTahaNaveed @jrgemignani
Fix issue 1955 - List comprehension in WHERE clause (#2094)
3b67b18 
- Fixed issue when MATCH clause variable is referenced inside list
  comprehension in WHERE clause or in property constraint.
- Added regression tests.
jrgemignani pushed a commit that referenced this pull request Jun 17, 2025
@MuhammadTahaNaveed @jrgemignani
Reimplement list comprehension (#2169)
a6e33d5 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
jrgemignani pushed a commit that referenced this pull request Jun 17, 2025
@MuhammadTahaNaveed
Reimplement list comprehension (#2169) (#2188)
99f2c23 
* Revert "Fix issue 1955 - List comprehension in WHERE clause (#2094)"

This reverts commit 0f0d9be.

* Revert "Fix error using list comprehension with WITH * (#1838)"

This reverts commit 5e08a2f.

* Revert "Fix shift/reduce conflict in grammar (#1719)"

This reverts commit fab3119.

* Revert "Implement list comprehension (#1610)"

This reverts commit 3b2b394.

* Reimplement list comprehension

- Reimplement list comprehension to use ARRAY sublinks.
- Some test results were not correct. All the test results that are
  modified are correct and are verified with neo4j.
- Also resolves the issue of using list comprehension in MERGE clause (1611)
  and issue 1850

* Add expression tree walkers for cypher nodes

- Added cypher_raw_expr_tree_walker and cypher_expr_tree_walker, based
  on Postgres's raw_expression_tree_walker and expression_tree_walker.
  These follow the same walker API as Postgres and add support for
  Cypher-specific nodes.
- Also added the agtype[] to agtype func and typecast to 1.5.0-y.y.y.sql
- Simplifies logic for cypher_subquery handling in where clause.
- Fixes a crash when list comprehension in the WHERE clause references a
  variable from the preceding MATCH clause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgemignani jrgemignani jrgemignani approved these changes

Assignees
No one assigned
Labels
master override-stale To keep issues/PRs untouched from stale action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List comprehension in WHERE clause results in server process segmentation fault
2 participants
@MuhammadTahaNaveed @jrgemignani
0