10000 Fix 3.2 ci by Stellar1999 · Pull Request #15136 · apache/dubbo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 3.2 ci #15136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

Fix 3.2 ci #15136

merged 1 commit into from
Feb 17, 2025

Conversation

Stellar1999
Copy link
Contributor

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

< 8000 div data-view-component="true" class="TimelineItem TimelineItem--condensed">
@Stellar1999
Fix GitHub action
7945c8d
@codecov-commenter
Copy link
codecov-commenter commented Feb 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.39%. Comparing base (a9fedd5) to head (7945c8d).
Report is 42 commits behind head on 3.2.

❗ There is a different number of reports uploaded between BASE (a9fedd5) and HEAD (7945c8d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a9fedd5) HEAD (7945c8d)
1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##                3.2   #15136       +/-   ##
=============================================
- Coverage     70.16%   41.39%   -28.77%     
- Complexity        0    10513    +10513     
=============================================
  Files          1608     1652       +44     
  Lines         70239    71435     +1196     
  Branches      10123    10158       +35     
=============================================
- Hits          49282    29570    -19712     
- Misses        16310    37734    +21424     
+ Partials       4647     4131      -516
Flag Coverage Δ
integration-tests 38.32% <ø> (?)
samples-tests 36.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Stellar1999
Copy link
Contributor Author
Stellar1999 commented Feb 16, 2025 •
edited
Loading

The IT fix code needs to be merged as a priority. Ref:apache/dubbo-integration-cases#55

@Stellar1999 Stellar1999 marked this pull request as ready for review February 16, 2025 12:55
@Stellar1999
Copy link
Contributor Author

PTAL @AlbumenJ

@Stellar1999
Copy link
Contributor Author

It has already passed the CI verification in my own repository.
Ref:3.3:https://github.com/Stellar1999/dubbo/actions/runs/13354955097
Ref:3.2:https://github.com/Stellar1999/dubbo/actions/runs/13354944216

@zrlw
Copy link
Contributor
zrlw commented Feb 16, 2025

image
this problem should be fixed.

@Stellar1999
Copy link
Contributor Author

image this problem should be fixed.

Please read the comment first.

The IT fix code needs to be merged as a priority. Ref:apache/dubbo-integration-cases#55

@AlbumenJ AlbumenJ merged commit 29472c0 into apache:3.2 Feb 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stellar1999 @codecov-commenter @zrlw @AlbumenJ
0